Re: [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp

[Tom de Vries <tdevries@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

On 4/26/23 09:08, Andreas Schwab wrote:
> On Apr 26 2023, Tom de Vries via Gdb-patches wrote:
> 
>> FWIW, reading a bit more about it I get the impression also set is
>> idiomatic, so I came up with this:
>> ...
>> set res [lmap v $l { set v $v/c ; set v }]
>> ...
>> which works as well.
> 
> You won't need the second set, though, since the first set already
> returns the assigned value.
> 

Andreas, thanks for the review.

Committed as attached.

Thanks,
- Tom


[-- Attachment #2: 0001-gdb-testsuite-Use-set-in-lmap-in-gdb.dwarf2-dw2-abs-.patch --]
[-- Type: text/x-patch, Size: 1270 bytes --]

From 2cef3ed1040d4f5191fbc53ebc82fdb3a635f7d1 Mon Sep 17 00:00:00 2001
From: Tom de Vries <tdevries@suse.de>
Date: Tue, 2 May 2023 17:28:50 +0200
Subject: [pushed] [gdb/testsuite] Use set in lmap in
 gdb.dwarf2/dw2-abs-hi-pc.exp

In gdb.dwarf2/dw2-abs-hi-pc.exp we do:
...
set sources [lmap i $sources { expr { "$srcdir/$subdir/$i" } }]
...

The use of expr is not idiomatic.  Fix this by using set instead:
...
set sources [lmap i $sources { set tmp $srcdir/$subdir/$i }]
...

Reported-By: Tom Tromey <tom@tromey.com>
Reviewed-By: Andreas Schwab <schwab@suse.de>
---
 gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp b/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
index 2ea6a5cea00..5b5d678ec7a 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp
@@ -24,7 +24,7 @@ set sources \
 	 ${testfile}.c \
 	 ${testfile}-hello.c \
 	 ${testfile}-world.c]
-set sources [lmap i $sources { expr { "$srcdir/$subdir/$i" } }]
+set sources [lmap i $sources { set tmp $srcdir/$subdir/$i }]
 
 lassign [function_range hello $sources] \
     hello_start hello_len

base-commit: b545d4239bedf9001926efd55da2aa2bd2bbb94a
-- 
2.35.3