From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Tom de Vries <tdevries@suse.de>
Subject: Re: [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp
Date: Tue, 25 Apr 2023 12:38:48 -0600 [thread overview]
Message-ID: <878refyfgn.fsf@tromey.com> (raw)
In-Reply-To: <2a3587b4-98c4-263a-7deb-9530fbf06c57@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 24 Apr 2023 22:22:44 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> +set sources [lmap i $sources { subst $srcdir/$subdir/$i }]
Tom> My working set of tcl is a bit random, so I don't know what idiomatic
Tom> is and what not.
No worries, Tcl expertise isn't exactly a headline skill.
Tom> I agree that subst is neater since it needs less quoting.
It probably has to be { subst { $srcdir/$subdir/$i } }
since otherwise there will be a second substitution if, say, the srcdir
has a $ or [] in it.
Tom
next prev parent reply other threads:[~2023-04-25 18:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 12:48 Tom de Vries
2023-04-24 12:48 ` [pushed 2/4] [gdb/testsuite] Add basic lmap for tcl < 8.6 Tom de Vries
2023-04-24 12:48 ` [pushed 3/4] [gdb/testsuite] Fix gdb.multi/multi-arch.exp on powerpc64le Tom de Vries
2023-04-24 12:48 ` [pushed 4/4] [gdb/testsuite] Require GCC >= 5.x.x in gdb.base/utf8-identifiers.exp Tom de Vries
2023-04-24 16:48 ` [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp Tom Tromey
2023-04-24 20:22 ` Tom de Vries
2023-04-25 18:38 ` Tom Tromey [this message]
2023-04-26 6:34 ` Tom de Vries
2023-04-26 7:08 ` Andreas Schwab
2023-05-02 15:38 ` Tom de Vries
2023-04-27 13:39 ` Tom Tromey
2023-05-02 15:40 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878refyfgn.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).