* source search with correct return type for "Expression not found"
@ 2021-11-03 22:09 Simon Sobisch
2021-11-04 0:43 ` Simon Marchi
0 siblings, 1 reply; 2+ messages in thread
From: Simon Sobisch @ 2021-11-03 22:09 UTC (permalink / raw)
To: gdb-patches
Currently the user only gets output of this message, but not error.
The later is especially different handled in GDB frontends and with mi
gdb/source.c, line 1709:
- printf_filtered (_("Expression not found\n"));
+ error (_("Expression not found"));
Nice side effect: one msgid less, because on line 1649 it is actually
used that way.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: source search with correct return type for "Expression not found"
2021-11-03 22:09 source search with correct return type for "Expression not found" Simon Sobisch
@ 2021-11-04 0:43 ` Simon Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2021-11-04 0:43 UTC (permalink / raw)
To: Simon Sobisch, gdb-patches
On 2021-11-03 18:09, Simon Sobisch via Gdb-patches wrote:
> Currently the user only gets output of this message, but not error.
> The later is especially different handled in GDB frontends and with mi
>
> gdb/source.c, line 1709:
>
> - printf_filtered (_("Expression not found\n"));
> + error (_("Expression not found"));
>
> Nice side effect: one msgid less, because on line 1649 it is actually used that way.
Hi,
Could you please send a proper git-generated patch (using
git-send-email, ideally)?
Also, in the commit message, please provide an example of the commands
you are using, with their output (before and after), explaining what
needs to be fixed.
Thanks,
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-04 0:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 22:09 source search with correct return type for "Expression not found" Simon Sobisch
2021-11-04 0:43 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).