From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"cel@us.ibm.com" <cel@us.ibm.com>
Cc: "will_schmidt@vnet.ibm.com" <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH] PowerPC, fix gdb.base/retval-large-struct.exp
Date: Thu, 17 Nov 2022 12:57:18 +0000 [thread overview]
Message-ID: <6606abb71b4b8a5f5d546f1db62f6d871fd6e7ac.camel@de.ibm.com> (raw)
In-Reply-To: <71926c391f43cee2051ea0c9b449ec0aecc847ec.camel@us.ibm.com>
Carl Love <cel@us.ibm.com> wrote:
>Currently the test gdb.base/retval-large-struct.exp is not able to
>access the return buffer address for the data being returned by the
>function. The functionality needed to obtain the value of r3 which
>holds the return buffer address on entry to the function was recently
>added in a new gdb method. This new method can be used by this test to
>allow it to correctly access the data being returned by the function.
Are there any more test cases that should get -fvar-tracking now?
In the long run, it might be good to work with GCC developers to see
if we can't have entry value DWARF records emitted (at least for
simple cases like the return buffer address) even without variable
tracking ...
In any case, for now this patch certainly seems reasonable.
>PowerPC, fix gdb.base/retval-large-struct.exp
This is OK.
Thanks,
Ulrich
next prev parent reply other threads:[~2022-11-17 12:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 22:11 Carl Love
2022-11-17 12:57 ` Ulrich Weigand [this message]
2022-11-17 16:18 ` Carl Love
2022-11-18 14:46 ` Tom de Vries
2022-11-18 16:04 ` Ulrich Weigand
2022-11-18 16:14 ` Carl Love
2022-11-18 16:25 ` Tom de Vries
2022-11-18 19:11 ` Carl Love
2022-11-19 6:42 ` Tom de Vries
2022-11-23 12:44 ` Ulrich Weigand
2023-03-07 18:59 ` Tom Tromey
2023-03-08 13:48 ` Ulrich Weigand
2023-03-08 15:15 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6606abb71b4b8a5f5d546f1db62f6d871fd6e7ac.camel@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).