From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"tdevries@suse.de" <tdevries@suse.de>,
"cel@us.ibm.com" <cel@us.ibm.com>
Cc: "will_schmidt@vnet.ibm.com" <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH] PowerPC, fix gdb.base/retval-large-struct.exp
Date: Fri, 18 Nov 2022 16:04:53 +0000 [thread overview]
Message-ID: <fedd606083102c4b3a597ee225aa4f8d9825337d.camel@de.ibm.com> (raw)
In-Reply-To: <a08df8bd-e6b7-f6c7-cf46-a5cf04c0c607@suse.de>
Tom de Vries <tdevries@suse.de> wrote:
>AFAIU, needing -fvar-tracking is specific to powerpc, so we should limit
>it's impact to that target.
>
>And it's a gcc compiler flag, so perhaps we should limit it's impact to
>that as well.
No, it's not really powerpc specific - the same mechanism can be
used on many other platforms with an ABI that uses a return buffer
address that is not preserved. (E.g. we're currently looking into
enabling it on s390x.)
And given that the flag is harmless if it's available (which the
test verifies), I think it makes sense to just always enable it.
(In fact, I think the compiler should really provide DWARF entry
value records -for simple cases- always, even if -fvar-tracking
is not enabled. That would make the problem go away.)
Bye,
Ulrich
next prev parent reply other threads:[~2022-11-18 16:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 22:11 Carl Love
2022-11-17 12:57 ` Ulrich Weigand
2022-11-17 16:18 ` Carl Love
2022-11-18 14:46 ` Tom de Vries
2022-11-18 16:04 ` Ulrich Weigand [this message]
2022-11-18 16:14 ` Carl Love
2022-11-18 16:25 ` Tom de Vries
2022-11-18 19:11 ` Carl Love
2022-11-19 6:42 ` Tom de Vries
2022-11-23 12:44 ` Ulrich Weigand
2023-03-07 18:59 ` Tom Tromey
2023-03-08 13:48 ` Ulrich Weigand
2023-03-08 15:15 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fedd606083102c4b3a597ee225aa4f8d9825337d.camel@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).