Re: [PATCH] PowerPC, fix gdb.base/retval-large-struct.exp

[Tom Tromey <tromey@adacore.com>]

>>>>> "Ulrich" == Ulrich Weigand via Gdb-patches <gdb-patches@sourceware.org> writes:

Ulrich> No, it's not really powerpc specific - the same mechanism can be
Ulrich> used on many other platforms with an ABI that uses a return buffer
Ulrich> address that is not preserved.  (E.g. we're currently looking into
Ulrich> enabling it on s390x.)

I am curious if it makes sense to enable for 32-bit PPC.

That is, the appended seems to help with a "large struct return" test
case we have internally, but I don't know the PPC ABI well enough to
know if it's really correct, or if it's just working by accident.

Tom

diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index 261ce77345e..218fb35efed 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -8249,7 +8249,11 @@ rs6000_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 				       ppc64_sysv_get_return_buf_addr);
     }
   else
-    set_gdbarch_return_value (gdbarch, ppc_sysv_abi_return_value);
+    {
+      set_gdbarch_return_value (gdbarch, ppc_sysv_abi_return_value);
+      set_gdbarch_get_return_buf_addr (gdbarch,
+				       ppc64_sysv_get_return_buf_addr);
+    }
 
   /* Set lr_frame_offset.  */
   if (wordsize == 8)