Re: [PATCH] PowerPC, fix gdb.base/retval-large-struct.exp

[Tom de Vries <tdevries@suse.de>]

On 11/16/22 23:11, Carl Love via Gdb-patches wrote:
> -if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
> +set additional_flags ""
> +
> +if {[have_fvar_tracking]} {
> +    set additional_flags "additional_flags= -fvar-tracking"
> +}
> +
> +if {[prepare_for_testing "failed to prepare" $testfile $srcfile [list debug $additional_flags]]} {
>       return -1
>   }
>   

AFAIU, needing -fvar-tracking is specific to powerpc, so we should limit 
it's impact to that target.

And it's a gcc compiler flag, so perhaps we should limit it's impact to 
that as well.

And if we indeed need it but it's not available, we should skip the test 
(or xfail the failing bit), because we cannot expect it to succeed.

So how about something like this:
...
set flags {}

lappend flags debug

if { [istarget powerpc*-*-*] && [is_c_compiler_gcc] } {
     if { [have_fvar_tracking] } {
         lappend flags -fvar-tracking
     } else {
         unsupported "gcc used, -fvar-tracking needed"
         return -1
     }
}

if {[prepare_for_testing "failed to prepare" $testfile $srcfile $flags]} {
        return -1
}
...

Thanks,
- Tom