From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"tromey@adacore.com" <tromey@adacore.com>
Cc: "will_schmidt@vnet.ibm.com" <will_schmidt@vnet.ibm.com>,
"tdevries@suse.de" <tdevries@suse.de>,
"cel@us.ibm.com" <cel@us.ibm.com>
Subject: Re: [PATCH] PowerPC, fix gdb.base/retval-large-struct.exp
Date: Wed, 8 Mar 2023 13:48:25 +0000 [thread overview]
Message-ID: <af426b06be706ab5801e08574bb1f731a5fcac8b.camel@de.ibm.com> (raw)
In-Reply-To: <87cz5ks7zw.fsf@tromey.com>
Tom Tromey <tromey@adacore.com> wrote:
>Ulrich> No, it's not really powerpc specific - the same mechanism can be
>Ulrich> used on many other platforms with an ABI that uses a return buffer
>Ulrich> address that is not preserved. (E.g. we're currently looking into
>Ulrich> enabling it on s390x.)
>
>I am curious if it makes sense to enable for 32-bit PPC.
That would make sense, yes. The 32-bit PPC ABI uses r3 as the
return address pointer just like the 64-bit ABIs.
>That is, the appended seems to help with a "large struct return" test
>case we have internally, but I don't know the PPC ABI well enough to
>know if it's really correct, or if it's just working by accident.
This looks good to me. The only (cosmetic) nit might be that if
the function is installed for both 32-bit and 64-bit tdeps,
convention seems to be that the function should be called ppc_...
then, not ppc64_...
Bye,
Ulrich
next prev parent reply other threads:[~2023-03-08 13:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 22:11 Carl Love
2022-11-17 12:57 ` Ulrich Weigand
2022-11-17 16:18 ` Carl Love
2022-11-18 14:46 ` Tom de Vries
2022-11-18 16:04 ` Ulrich Weigand
2022-11-18 16:14 ` Carl Love
2022-11-18 16:25 ` Tom de Vries
2022-11-18 19:11 ` Carl Love
2022-11-19 6:42 ` Tom de Vries
2022-11-23 12:44 ` Ulrich Weigand
2023-03-07 18:59 ` Tom Tromey
2023-03-08 13:48 ` Ulrich Weigand [this message]
2023-03-08 15:15 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af426b06be706ab5801e08574bb1f731a5fcac8b.camel@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
--cc=tromey@adacore.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).