Re: [PATCH] Rename gdbarch_tdep template function to gdbarch_tdep_cast for g++ 4.8

[Mark Wielaard <mark@klomp.org>]

Hi Andrew,

On Mon, 2022-07-25 at 12:19 +0100, Andrew Burgess wrote:
> Mark Wielaard <mark@klomp.org> writes:
> 
> > commit 08106042d "gdb: move the type cast into gdbarch_tdep" created
> > a template function with the same name as a struct gdbarch_tdep. This
> > confused g++ 4.8 believing the struct gdbarch_tdep was an incomplete
> > type. Fix this by renaming the template function to gdbarch_tdep_cast.
> 
> Honestly, I'm not a fan of the proposed new name.  Using names that end
> in _cast should, I think, be reserved for functions that exhibit casting
> like behaviour, i.e. take an object, or pointer, and return the same
> object, or pointer, converted to some alternative type, which isn't what
> we're doing here.
> 
> Instead of renaming the function, I'd like to propose that we rename the
> structure instead, so 'struct gdbarch_tdep' to 'struct
> gdbarch_tdep_base'.
> 
> Given the structure is only ever used as a base class, I think the new
> name is good, and this allows the function name to be left unchanged.
> 
> I tested this on a CentOS VM using g++ 4.8.5, and it seems to build
> fine.
> 
> Thoughts?

I agree with your reasoning. And now that you mention it I don't know
why I did rename the "cast" function instead of the base struct name. I
like your patch better.

Thanks,

Mark