Re: [PATCH 5/5] gdb: native target invalid architecture detection

[Pedro Alves <pedro@palves.net>]

On 2022-06-08 09:18, Luis Machado wrote:
> On 6/7/22 21:15, Pedro Alves wrote:
>> On 2022-06-07 19:42, Pedro Alves wrote:
>>
>>>      When we use gcc for arm-linux target, its file name can be different,
>>>      arm-linux-gnueabihf-gcc, arm-linux-gnueabi-gcc, or arm-none-linux-gnueabi-gcc,
>>>      so I add a variable ARM_CC_FOR_TARGET, so that user can set the name
>>>      of gcc for arm-linux target on aarch64, like:
>>
>> ...
>>
>>> Maybe it would be possible to come up with a way to default ARM_CC_FOR_TARGET to
>>> something that works for most people when testing aarch64, somehow.
>>
>> Maybe something like this?  Completely untested, other than hacking it such that
>> the aarch64 linux path is taken on my x86-64 box, to ensure the tcl at least parses
>> as expected.
>>
> 
> Thanks for the patch. I think it is fine to have some of these tests run conditionally
> based on the presence of an environment variable. What we're really missing is proper
> documentation of ARM_CC_FOR_TARGET, explaining what it does, when it should be enabled
> and under what conditions.

I agree we're missing documentation of that option, but I don't think fixing that should
prevent making "make check" with no options Just Work, with the ARM_CC_FOR_TARGET option
being there as an escape hatch for the less common scenario.  I think I should be able to
e.g., log in some aarch64 machine on the compile farm to test something, and not have
to remember to pass arch specific options to make check.

> 
> I wonder if putting that on the GDB manual, under a testing section, would work. The Wiki
> has an entry for testing, but I find it a bit chaotic. What do you say?

Testsuite options are documented in gdb/testsuite/README.