From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCHv4 0/6] Detect invalid casts of gdbarch_tdep structures
Date: Mon, 11 Jul 2022 11:46:42 +0100 [thread overview]
Message-ID: <87pmicsz8t.fsf@redhat.com> (raw)
In-Reply-To: <cover.1656426157.git.aburgess@redhat.com>
Ping!
Andrew Burgess <aburgess@redhat.com> writes:
> Changes since v3:
>
> - Title of series has changed as the last patch, relating to
> detection of incorrect architecture with a native target, have been
> dropped.
>
> - Patches #1 and #2 are unchanged,
>
> - Patch #3 has had minor updates based on feedback from Luis and Pedro,
>
> - Patch #4 is unchanged,
>
> - Patch #5 is new, based on Pedro's feedback,
>
> - Patch #6 has been updated to make use of the work added in patch
> #5.
>
> Changes since v2:
>
> - Patch #3 has been replaced after feedback from Luis. New patch
> fixes sider issues for arm, mips, and frv targets, this includes
> the issue the v2 patch fixed.
>
> - Nothing else has changed.
>
> Changes since v1:
>
> - Patches #1 and #2 are unchanged.
>
> - Patch #3 is new in this version.
>
> - Patch #4 is unchanged (was patch 3).
>
> - Patch #5 is updated inline with John's feedback (was patch 4).
>
> - Patch #6 is extended to handle multi-arch case for rs6000/ppc and
> arm/aarch64, commit message is updated to discuss these cases, as
> well as mentioning i386/x86-64 (was patch 5).
>
> ---
>
> Andrew Burgess (6):
> gdb/arm: move fetch of arm_gdbarch_tdep to a more inner scope
> gdb/mips: rewrite show_mask_address
> gdb: select suitable thread for gdbarch_adjust_breakpoint_address
> gdb: move the type cast into gdbarch_tdep
> gdbsupport: add checked_static_cast
> gdb: ensure the cast in gdbarch_tdep is valid
>
> gdb/aarch64-fbsd-nat.c | 4 +-
> gdb/aarch64-fbsd-tdep.c | 6 +-
> gdb/aarch64-linux-nat.c | 20 ++--
> gdb/aarch64-linux-tdep.c | 10 +-
> gdb/aarch64-newlib-tdep.c | 2 +-
> gdb/aarch64-tdep.c | 48 ++++-----
> gdb/aix-thread.c | 28 +++---
> gdb/alpha-linux-tdep.c | 2 +-
> gdb/alpha-netbsd-tdep.c | 2 +-
> gdb/alpha-obsd-tdep.c | 2 +-
> gdb/alpha-tdep.c | 14 +--
> gdb/amd64-darwin-tdep.c | 2 +-
> gdb/amd64-fbsd-nat.c | 4 +-
> gdb/amd64-fbsd-tdep.c | 4 +-
> gdb/amd64-linux-tdep.c | 8 +-
> gdb/amd64-netbsd-tdep.c | 2 +-
> gdb/amd64-obsd-tdep.c | 2 +-
> gdb/amd64-sol2-tdep.c | 2 +-
> gdb/amd64-tdep.c | 34 +++----
> gdb/amd64-windows-tdep.c | 2 +-
> gdb/arc-linux-tdep.c | 4 +-
> gdb/arc-newlib-tdep.c | 2 +-
> gdb/arc-tdep.c | 8 +-
> gdb/arch-utils.c | 6 +-
> gdb/arm-fbsd-nat.c | 4 +-
> gdb/arm-fbsd-tdep.c | 6 +-
> gdb/arm-linux-nat.c | 8 +-
> gdb/arm-linux-tdep.c | 4 +-
> gdb/arm-netbsd-nat.c | 8 +-
> gdb/arm-netbsd-tdep.c | 4 +-
> gdb/arm-none-tdep.c | 2 +-
> gdb/arm-obsd-tdep.c | 2 +-
> gdb/arm-tdep.c | 142 ++++++++++++++-------------
> gdb/arm-wince-tdep.c | 2 +-
> gdb/avr-tdep.c | 12 +--
> gdb/bfin-tdep.c | 4 +-
> gdb/breakpoint.c | 27 +++--
> gdb/cris-linux-tdep.c | 2 +-
> gdb/cris-tdep.c | 18 ++--
> gdb/csky-tdep.c | 8 +-
> gdb/frv-tdep.c | 4 +-
> gdb/ft32-tdep.c | 2 +-
> gdb/gdbarch.h | 27 ++++-
> gdb/hppa-bsd-tdep.c | 2 +-
> gdb/hppa-linux-tdep.c | 4 +-
> gdb/hppa-tdep.c | 12 +--
> gdb/i386-bsd-tdep.c | 2 +-
> gdb/i386-darwin-tdep.c | 4 +-
> gdb/i386-fbsd-tdep.c | 4 +-
> gdb/i386-gnu-tdep.c | 2 +-
> gdb/i386-go32-tdep.c | 2 +-
> gdb/i386-linux-tdep.c | 4 +-
> gdb/i386-netbsd-tdep.c | 4 +-
> gdb/i386-nto-tdep.c | 6 +-
> gdb/i386-obsd-tdep.c | 2 +-
> gdb/i386-sol2-tdep.c | 2 +-
> gdb/i386-tdep.c | 98 +++++++++---------
> gdb/i386-windows-tdep.c | 2 +-
> gdb/i387-tdep.c | 20 ++--
> gdb/ia64-linux-tdep.c | 2 +-
> gdb/ia64-tdep.c | 12 +--
> gdb/loongarch-linux-tdep.c | 2 +-
> gdb/loongarch-tdep.c | 4 +-
> gdb/m32c-tdep.c | 58 +++++------
> gdb/m68hc11-tdep.c | 12 +--
> gdb/m68k-bsd-tdep.c | 2 +-
> gdb/m68k-linux-tdep.c | 2 +-
> gdb/m68k-tdep.c | 38 +++----
> gdb/mep-tdep.c | 6 +-
> gdb/mips-linux-tdep.c | 4 +-
> gdb/mips-tdep.c | 85 ++++++++--------
> gdb/mn10300-tdep.c | 2 +-
> gdb/mn10300-tdep.h | 2 +-
> gdb/msp430-tdep.c | 12 +--
> gdb/nds32-tdep.c | 20 ++--
> gdb/nios2-linux-tdep.c | 2 +-
> gdb/nios2-tdep.c | 4 +-
> gdb/or1k-tdep.c | 8 +-
> gdb/ppc-fbsd-nat.c | 4 +-
> gdb/ppc-fbsd-tdep.c | 8 +-
> gdb/ppc-linux-nat.c | 22 ++---
> gdb/ppc-linux-tdep.c | 18 ++--
> gdb/ppc-netbsd-nat.c | 6 +-
> gdb/ppc-netbsd-tdep.c | 2 +-
> gdb/ppc-obsd-nat.c | 4 +-
> gdb/ppc-obsd-tdep.c | 2 +-
> gdb/ppc-sysv-tdep.c | 22 ++---
> gdb/ppc64-tdep.c | 2 +-
> gdb/riscv-linux-tdep.c | 2 +-
> gdb/riscv-tdep.c | 26 ++---
> gdb/rl78-tdep.c | 8 +-
> gdb/rs6000-aix-nat.c | 6 +-
> gdb/rs6000-aix-tdep.c | 16 +--
> gdb/rs6000-lynx178-tdep.c | 4 +-
> gdb/rs6000-tdep.c | 132 ++++++++++++-------------
> gdb/rx-tdep.c | 2 +-
> gdb/s390-linux-tdep.c | 20 ++--
> gdb/s390-tdep.c | 42 ++++----
> gdb/sh-linux-tdep.c | 2 +-
> gdb/sh-netbsd-tdep.c | 2 +-
> gdb/sh-tdep.c | 8 +-
> gdb/sparc-linux-tdep.c | 4 +-
> gdb/sparc-netbsd-tdep.c | 2 +-
> gdb/sparc-sol2-tdep.c | 2 +-
> gdb/sparc-tdep.c | 14 +--
> gdb/sparc64-fbsd-tdep.c | 2 +-
> gdb/sparc64-linux-tdep.c | 4 +-
> gdb/sparc64-netbsd-tdep.c | 2 +-
> gdb/sparc64-obsd-tdep.c | 2 +-
> gdb/sparc64-sol2-tdep.c | 2 +-
> gdb/sparc64-tdep.c | 10 +-
> gdb/tic6x-linux-tdep.c | 6 +-
> gdb/tic6x-tdep.c | 6 +-
> gdb/v850-tdep.c | 6 +-
> gdb/windows-nat.c | 2 +-
> gdb/xtensa-linux-nat.c | 4 +-
> gdb/xtensa-linux-tdep.c | 2 +-
> gdb/xtensa-tdep.c | 54 +++++-----
> gdb/z80-tdep.c | 8 +-
> gdbsupport/gdb-checked-static-cast.h | 68 +++++++++++++
> 120 files changed, 811 insertions(+), 700 deletions(-)
> create mode 100644 gdbsupport/gdb-checked-static-cast.h
>
> --
> 2.25.4
next prev parent reply other threads:[~2022-07-11 10:46 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 14:30 [PATCH 0/5] Handle trying to use a native target with the wrong binary Andrew Burgess
2022-05-31 14:30 ` [PATCH 1/5] gdb/arm: move fetch of arm_gdbarch_tdep to a more inner scope Andrew Burgess
2022-06-01 7:58 ` Luis Machado
2022-05-31 14:30 ` [PATCH 2/5] gdb/mips: rewrite show_mask_address Andrew Burgess
2022-05-31 14:30 ` [PATCH 3/5] gdb: move the type cast into gdbarch_tdep Andrew Burgess
2022-06-01 8:01 ` Luis Machado
2022-05-31 14:30 ` [PATCH 4/5] gdb: ensure the cast in gdbarch_tdep is valid Andrew Burgess
2022-05-31 16:04 ` John Baldwin
2022-05-31 17:22 ` Andrew Burgess
2022-05-31 14:30 ` [PATCH 5/5] gdb: native target invalid architecture detection Andrew Burgess
2022-05-31 16:08 ` John Baldwin
2022-05-31 16:51 ` Andrew Burgess
2022-06-01 8:25 ` Luis Machado
2022-06-01 21:06 ` John Baldwin
2022-06-01 21:21 ` Christophe Lyon
2022-06-02 14:56 ` John Baldwin
2022-06-06 14:38 ` Andrew Burgess
2022-06-06 17:48 ` Andrew Burgess
2022-06-07 11:03 ` Luis Machado
2022-06-07 18:42 ` Pedro Alves
2022-06-07 20:15 ` Pedro Alves
2022-06-08 8:18 ` Luis Machado
2022-06-08 10:17 ` Pedro Alves
2022-06-08 7:54 ` Luis Machado
2022-06-08 10:12 ` Pedro Alves
2022-06-08 11:20 ` [PATCH v2] aarch64: Add fallback if ARM_CC_FOR_TARGET not set (was: Re: [PATCH 5/5] gdb: native target invalid architecture detection) Pedro Alves
2022-06-08 12:50 ` Luis Machado
2022-06-08 13:23 ` Pedro Alves
2022-06-08 13:38 ` Andrew Burgess
2022-06-08 19:01 ` John Baldwin
2022-06-08 21:48 ` Pedro Alves
2022-06-09 16:31 ` John Baldwin
2022-06-10 13:08 ` [PATCHv2 0/6] Handle trying to use a native target with the wrong binary Andrew Burgess
2022-06-10 13:08 ` [PATCHv2 1/6] gdb/arm: move fetch of arm_gdbarch_tdep to a more inner scope Andrew Burgess
2022-06-10 13:08 ` [PATCHv2 2/6] gdb/mips: rewrite show_mask_address Andrew Burgess
2022-06-10 13:08 ` [PATCHv2 3/6] gdb/arm: avoid undefined behaviour in arm_frame_is_thumb Andrew Burgess
2022-06-10 15:21 ` Luis Machado
2022-06-10 15:49 ` Andrew Burgess
2022-06-10 16:29 ` Luis Machado
2022-06-10 13:08 ` [PATCHv2 4/6] gdb: move the type cast into gdbarch_tdep Andrew Burgess
2022-06-10 16:35 ` Luis Machado
2022-06-10 13:08 ` [PATCHv2 5/6] gdb: ensure the cast in gdbarch_tdep is valid Andrew Burgess
2022-06-10 13:08 ` [PATCHv2 6/6] gdb: native target invalid architecture detection Andrew Burgess
2022-06-10 16:20 ` John Baldwin
2022-06-10 16:31 ` Luis Machado
2022-06-13 16:15 ` [PATCHv3 0/6] Handle trying to use a native target with the wrong binary Andrew Burgess
2022-06-13 16:15 ` [PATCHv3 1/6] gdb/arm: move fetch of arm_gdbarch_tdep to a more inner scope Andrew Burgess
2022-06-13 16:15 ` [PATCHv3 2/6] gdb/mips: rewrite show_mask_address Andrew Burgess
2022-06-13 16:15 ` [PATCHv3 3/6] gdb: select suitable thread for gdbarch_adjust_breakpoint_address Andrew Burgess
2022-06-14 9:45 ` Luis Machado
2022-06-14 14:05 ` Andrew Burgess
2022-06-24 16:58 ` Pedro Alves
2022-06-13 16:15 ` [PATCHv3 4/6] gdb: move the type cast into gdbarch_tdep Andrew Burgess
2022-06-13 16:15 ` [PATCHv3 5/6] gdb: ensure the cast in gdbarch_tdep is valid Andrew Burgess
2022-06-24 18:15 ` Pedro Alves
2022-06-13 16:15 ` [PATCHv3 6/6] gdb: native target invalid architecture detection Andrew Burgess
2022-06-24 19:23 ` Pedro Alves
2022-06-27 16:27 ` Andrew Burgess
2022-06-27 21:38 ` Pedro Alves
2022-06-28 10:37 ` Andrew Burgess
2022-06-28 12:42 ` [PATCH v2] gdb+gdbserver/Linux: avoid reading registers while going through shell (was: Re: [PATCHv3 6/6] gdb: native target invalid architecture detection) Pedro Alves
2022-06-28 14:21 ` Andrew Burgess
2022-06-29 15:17 ` Simon Marchi
2022-06-29 16:22 ` [PATCH] Fix GDBserver regression due to change to avoid reading shell registers Pedro Alves
2022-06-29 16:38 ` Simon Marchi
2022-06-30 9:33 ` [PATCHv3 6/6] gdb: native target invalid architecture detection Andrew Burgess
2022-06-30 11:44 ` Pedro Alves
2022-07-11 10:47 ` Andrew Burgess
2022-06-24 10:15 ` [PATCHv3 0/6] Handle trying to use a native target with the wrong binary Andrew Burgess
2022-06-28 14:28 ` [PATCHv4 0/6] Detect invalid casts of gdbarch_tdep structures Andrew Burgess
2022-06-28 14:28 ` [PATCHv4 1/6] gdb/arm: move fetch of arm_gdbarch_tdep to a more inner scope Andrew Burgess
2022-06-28 14:28 ` [PATCHv4 2/6] gdb/mips: rewrite show_mask_address Andrew Burgess
2022-06-28 14:28 ` [PATCHv4 3/6] gdb: select suitable thread for gdbarch_adjust_breakpoint_address Andrew Burgess
2022-06-28 14:28 ` [PATCHv4 4/6] gdb: move the type cast into gdbarch_tdep Andrew Burgess
2022-06-28 14:28 ` [PATCHv4 5/6] gdbsupport: add checked_static_cast Andrew Burgess
2022-06-28 14:28 ` [PATCHv4 6/6] gdb: ensure the cast in gdbarch_tdep is valid Andrew Burgess
2022-07-11 10:46 ` Andrew Burgess [this message]
2022-07-21 18:21 ` [PATCHv4 0/6] Detect invalid casts of gdbarch_tdep structures Andrew Burgess
2022-07-22 0:50 ` Luis Machado
2022-07-23 0:02 ` [PATCH] Rename gdbarch_tdep template function to gdbarch_tdep_cast for g++ 4.8 Mark Wielaard
2022-07-25 11:19 ` Andrew Burgess
2022-07-25 11:27 ` Mark Wielaard
2022-07-26 11:05 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmicsz8t.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).