Re: [PATCH v6 10/10] btrace: Extend ptwrite event decoding.

[Eli Zaretskii <eliz@gnu.org>]

> From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, "Metzger,
>  Markus T" <markus.t.metzger@intel.com>
> Date: Fri, 16 Sep 2022 14:34:39 +0000
> 
> > > > Can we rephrase the "and in Python" part to be less confusing and
> > > > ambiguous?  (Also, there's an extraneous blank character there.)
> > >
> > > The NEWS file very often says "in Python".
> > > But it is a fair point. How about "and in the Python API?"
> > 
> > I think it is better to use the same wording as you did in the manual.
> 
> Which is? I can't find anything similar.

 Auxiliary information is by default printed during
 @code{record instruction-history}, @code{record function-call-history},
 and all stepping commands and is accessible in Python as a
 @code{RecordAuxiliary} object.

> > > > Btw, it sounds like this functionality is only available if GDB was
> > > > built with Python?  If so, I think other places where you mention this
> > > > in the manual should indicate that the feature is only available
> > > > through Python.
> > >
> > > That is true. Yet most of the documentation is in python.texi for that
> > reason.
> > > Do you think that is not enough?
> > 
> > I was talking about stuff outside of python.texi.
> 
> I listed all the stuff outside of python.texi in my previous answer and mentioned why
> I don't see any place where your suggestion would make sense.

Here:

  --- a/gdb/doc/gdb.texinfo
  +++ b/gdb/doc/gdb.texinfo
  @@ -8017,8 +8017,9 @@ that function, the source lines for this instruction sequence (if the
   @code{/l} modifier is specified), and the instructions numbers that form
   the sequence (if the @code{/i} modifier is specified).  The function names
   are indented to reflect the call stack depth if the @code{/c} modifier is
  -specified.  The @code{/l}, @code{/i}, and @code{/c} modifiers can be given
  -together.
  +specified.  Printing auxiliary information is enabled by default and can be
  +omitted with the @code{/a} modifier.  The @code{/l}, @code{/i}, @code{/a},
  +and @code{/c} modifiers can be given together.

Here:

  --- a/gdb/doc/gdb.texinfo
  +++ b/gdb/doc/gdb.texinfo
  @@ -7545,6 +7545,10 @@ Moxie, PowerPC, PowerPC64, S/390, and x86 (i386/amd64) running
   GNU/Linux.  Process record and replay can be used both when native
   debugging, and when remote debugging via @code{gdbserver}.

  +When recording an inferior, @value{GDBN} may print additional auxiliary
  +information during stepping commands and commands displaying the execution
  +history.

And here:

  --- a/gdb/doc/gdb.texinfo
  +++ b/gdb/doc/gdb.texinfo
  @@ -7545,6 +7545,10 @@ Moxie, PowerPC, PowerPC64, S/390, and x86 (i386/amd64) running
   GNU/Linux.  Process record and replay can be used both when native
   debugging, and when remote debugging via @code{gdbserver}.

  +When recording an inferior, @value{GDBN} may print additional auxiliary
  +information during stepping commands and commands displaying the execution
  +history.