public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>
Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com
Subject: Re: [PATCH v6 10/10] btrace: Extend ptwrite event decoding.
Date: Fri, 16 Sep 2022 17:21:04 +0300	[thread overview]
Message-ID: <83sfkr2yen.fsf@gnu.org> (raw)
In-Reply-To: <MN2PR11MB456678E2951D7451DEEEFBD08E489@MN2PR11MB4566.namprd11.prod.outlook.com> (felix.willgerodt@intel.com)

> From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, "Metzger,
>  Markus T" <markus.t.metzger@intel.com>
> Date: Fri, 16 Sep 2022 14:02:07 +0000
> 
> > >  *** Changes since GDB 12
> > >
> > > +* GDB now supports printing of ptwrite payloads from the Intel Processor
> > > +  Trace during 'record instruction-history', 'record function-call-history',
> > > +  all stepping commands and in  Python.  Printing is customizable via a
> > 
> > Can we rephrase the "and in Python" part to be less confusing and
> > ambiguous?  (Also, there's an extraneous blank character there.)
> 
> The NEWS file very often says "in Python".
> But it is a fair point. How about "and in the Python API?"

I think it is better to use the same wording as you did in the manual.

> > Btw, it sounds like this functionality is only available if GDB was
> > built with Python?  If so, I think other places where you mention this
> > in the manual should indicate that the feature is only available
> > through Python.
> 
> That is true. Yet most of the documentation is in python.texi for that reason.
> Do you think that is not enough?

I was talking about stuff outside of python.texi.

  reply	other threads:[~2022-09-16 14:21 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 11:36 [PATCH v6 00/10] Extensions for PTWRITE Felix Willgerodt
2022-09-16 11:36 ` [PATCH v6 01/10] btrace: Introduce auxiliary instructions Felix Willgerodt
2022-09-16 11:46   ` Eli Zaretskii
2022-09-16 14:01     ` Willgerodt, Felix
2022-09-16 14:18       ` Eli Zaretskii
2022-09-16 11:36 ` [PATCH v6 02/10] btrace: Enable auxiliary instructions in record instruction-history Felix Willgerodt
2022-09-16 11:50   ` Eli Zaretskii
2022-09-16 11:36 ` [PATCH v6 03/10] btrace: Enable auxiliary instructions in record function-call-history Felix Willgerodt
2022-09-16 11:43   ` Eli Zaretskii
2022-09-16 11:36 ` [PATCH v6 04/10] btrace: Handle stepping and goto for auxiliary instructions Felix Willgerodt
2022-09-16 11:36 ` [PATCH v6 05/10] python: Introduce gdb.RecordAuxiliary class Felix Willgerodt
2022-09-16 12:04   ` Eli Zaretskii
2022-09-16 11:36 ` [PATCH v6 06/10] python: Add clear() to gdb.Record Felix Willgerodt
2022-09-16 11:49   ` Eli Zaretskii
2022-09-16 11:36 ` [PATCH v6 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt Felix Willgerodt
2022-09-16 11:49   ` Eli Zaretskii
2022-09-16 14:02     ` Willgerodt, Felix
2022-10-19 14:41   ` Metzger, Markus T
2022-10-20 11:49     ` Willgerodt, Felix
2022-10-20 12:31       ` Metzger, Markus T
2022-09-16 11:36 ` [PATCH v6 08/10] btrace, linux: Enable ptwrite packets Felix Willgerodt
2022-09-16 11:36 ` [PATCH v6 09/10] btrace, python: Enable ptwrite filter registration Felix Willgerodt
2022-10-19 14:41   ` Metzger, Markus T
2022-10-20 11:49     ` Willgerodt, Felix
2022-10-20 12:33       ` Metzger, Markus T
2022-09-16 11:36 ` [PATCH v6 10/10] btrace: Extend ptwrite event decoding Felix Willgerodt
2022-09-16 12:01   ` Eli Zaretskii
2022-09-16 14:02     ` Willgerodt, Felix
2022-09-16 14:21       ` Eli Zaretskii [this message]
2022-09-16 14:34         ` Willgerodt, Felix
2022-09-16 15:29           ` Eli Zaretskii
2022-09-19 11:23             ` Willgerodt, Felix
2022-10-19 14:45 ` [PATCH v6 00/10] Extensions for PTWRITE Metzger, Markus T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sfkr2yen.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=felix.willgerodt@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).