RE: [PATCH v6 01/10] btrace: Introduce auxiliary instructions.

["Willgerodt, Felix" <felix.willgerodt@intel.com>]

Thanks for reviewing this again.
In the cover letter I mentioned that basically all doc parts have already been
approved by you. As I didn't want to waste your time, having you review the
same text again and again. Is there a better way to let you know that you
approved this already? Or did you read the cover letter and intentionally reviewed it?
(Which is totally fine.)

I just don't want to waste your time, I do appreciate the feedback!

> -----Original Message-----
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Freitag, 16. September 2022 13:46
> To: Willgerodt, Felix <felix.willgerodt@intel.com>
> Cc: gdb-patches@sourceware.org; Metzger, Markus T
> <markus.t.metzger@intel.com>
> Subject: Re: [PATCH v6 01/10] btrace: Introduce auxiliary instructions.
> 
> > Date: Fri, 16 Sep 2022 13:36:37 +0200
> > From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> >
> > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> > index 238a49b027d..0f769f5e24c 100644
> > --- a/gdb/doc/gdb.texinfo
> > +++ b/gdb/doc/gdb.texinfo
> > @@ -7545,6 +7545,10 @@ Moxie, PowerPC, PowerPC64, S/390, and x86
> (i386/amd64) running
> >  GNU/Linux.  Process record and replay can be used both when native
> >  debugging, and when remote debugging via @code{gdbserver}.
> >
> > +When recording an inferior, @value{GDBN} may print additional auxiliary
> > +information during stepping commands and commands displaying the
> execution
> > +history.
> > +
> >  For architecture environments that support process record and replay,
> >  @value{GDBN} provides the following commands:
> 
> "Auxiliary" and "additional" both say almost the same thing, so I'd
> lose the "additional" part.

Thanks, I removed it locally.

> And I wonder whether this additional sentence really adds something
> important to the text, since it doesn't say what and when will be
> displayed in addition.  So maybe we don't need this addition at all?

The auxiliary instructions are designed to be generic. To be
able to use them for other features in the future. I think a "definition"
of the concept is needed, as it is user exposed via the /a modifiers later
in patch 2 and 3. Which are also documented and basically reference
this "definition" here.

Thanks,
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928