From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v6 09/10] btrace, python: Enable ptwrite filter registration.
Date: Thu, 20 Oct 2022 11:49:13 +0000 [thread overview]
Message-ID: <MN2PR11MB4566D64BF99744C24C6A1F8E8E2A9@MN2PR11MB4566.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM8PR11MB57493980AACA30AD8DDC57A9DE2B9@DM8PR11MB5749.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Metzger, Markus T <markus.t.metzger@intel.com>
> Sent: Mittwoch, 19. Oktober 2022 16:42
> To: Willgerodt, Felix <felix.willgerodt@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: RE: [PATCH v6 09/10] btrace, python: Enable ptwrite filter
> registration.
>
> Hello Felix,
>
> >With this patch a default ptwrite filter is registered upon start of GDB.
> >It prints the plain ptwrite payload as hex. The default filter can be
> >overwritten by registering a custom filter in python or by registering
> >"None", for no output at all. Registering a filter function creates per
> >thread copies to allow unique internal states per thread.
> >---
> > gdb/btrace.c | 4 ++
> > gdb/btrace.h | 8 ++++
> > gdb/data-directory/Makefile.in | 1 +
> > gdb/extension-priv.h | 5 ++
> > gdb/extension.c | 13 +++++
> > gdb/extension.h | 3 ++
> > gdb/guile/guile.c | 1 +
> > gdb/python/lib/gdb/ptwrite.py | 80
> +++++++++++++++++++++++++++++++
> > gdb/python/py-record-btrace.c | 88
> ++++++++++++++++++++++++++++++++++
> > gdb/python/py-record-btrace.h | 8 ++++
> > gdb/python/python-internal.h | 3 ++
> > gdb/python/python.c | 2 +
> > 12 files changed, 216 insertions(+)
> > create mode 100644 gdb/python/lib/gdb/ptwrite.py
>
> Looks good to me with one small nit and a question.
>
> >+ /* Function pointer to the ptwrite callback. Returns the string returned
> >+ by the ptwrite filter function. */
> >+ std::string (*ptw_callback_fun) (const uint64_t payload, const uint64_t ip,
> >+ const void *ptw_context);
>
> This should probably be initialized to nullptr.
Right, I will do that.
> >+def get_filter():
> >+ """Returns the filters of the current thread."""
> >+ # The key is of this format to enable an per-inferior cleanup when an
> >+ # inferior exits.
> >+ key = f"{gdb.selected_inferior().pid}.{gdb.selected_thread().ptid[1]}"
> >+
> >+ # Create a new filter for new threads.
> >+ if key not in _ptwrite_filter.keys():
> >+ _ptwrite_filter[key] = deepcopy(_ptwrite_filter["global"])
>
> Do we even need this "global" filter in the dict? Could we just use the
> default_filter, here?
I don't see how. In case a custom filter is registered and
a new thread spawns, we need "global". We can't copy default_filter and
we can't copy from other threads, as they might have internal state already.
Thanks,
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-10-20 11:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 11:36 [PATCH v6 00/10] Extensions for PTWRITE Felix Willgerodt
2022-09-16 11:36 ` [PATCH v6 01/10] btrace: Introduce auxiliary instructions Felix Willgerodt
2022-09-16 11:46 ` Eli Zaretskii
2022-09-16 14:01 ` Willgerodt, Felix
2022-09-16 14:18 ` Eli Zaretskii
2022-09-16 11:36 ` [PATCH v6 02/10] btrace: Enable auxiliary instructions in record instruction-history Felix Willgerodt
2022-09-16 11:50 ` Eli Zaretskii
2022-09-16 11:36 ` [PATCH v6 03/10] btrace: Enable auxiliary instructions in record function-call-history Felix Willgerodt
2022-09-16 11:43 ` Eli Zaretskii
2022-09-16 11:36 ` [PATCH v6 04/10] btrace: Handle stepping and goto for auxiliary instructions Felix Willgerodt
2022-09-16 11:36 ` [PATCH v6 05/10] python: Introduce gdb.RecordAuxiliary class Felix Willgerodt
2022-09-16 12:04 ` Eli Zaretskii
2022-09-16 11:36 ` [PATCH v6 06/10] python: Add clear() to gdb.Record Felix Willgerodt
2022-09-16 11:49 ` Eli Zaretskii
2022-09-16 11:36 ` [PATCH v6 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt Felix Willgerodt
2022-09-16 11:49 ` Eli Zaretskii
2022-09-16 14:02 ` Willgerodt, Felix
2022-10-19 14:41 ` Metzger, Markus T
2022-10-20 11:49 ` Willgerodt, Felix
2022-10-20 12:31 ` Metzger, Markus T
2022-09-16 11:36 ` [PATCH v6 08/10] btrace, linux: Enable ptwrite packets Felix Willgerodt
2022-09-16 11:36 ` [PATCH v6 09/10] btrace, python: Enable ptwrite filter registration Felix Willgerodt
2022-10-19 14:41 ` Metzger, Markus T
2022-10-20 11:49 ` Willgerodt, Felix [this message]
2022-10-20 12:33 ` Metzger, Markus T
2022-09-16 11:36 ` [PATCH v6 10/10] btrace: Extend ptwrite event decoding Felix Willgerodt
2022-09-16 12:01 ` Eli Zaretskii
2022-09-16 14:02 ` Willgerodt, Felix
2022-09-16 14:21 ` Eli Zaretskii
2022-09-16 14:34 ` Willgerodt, Felix
2022-09-16 15:29 ` Eli Zaretskii
2022-09-19 11:23 ` Willgerodt, Felix
2022-10-19 14:45 ` [PATCH v6 00/10] Extensions for PTWRITE Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4566D64BF99744C24C6A1F8E8E2A9@MN2PR11MB4566.namprd11.prod.outlook.com \
--to=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).