RE: [PATCH v6 09/10] btrace, python: Enable ptwrite filter registration.

["Metzger, Markus T" <markus.t.metzger@intel.com>]

Hello Felix,

>> >+def get_filter():
>> >+    """Returns the filters of the current thread."""
>> >+    # The key is of this format to enable an per-inferior cleanup when an
>> >+    # inferior exits.
>> >+    key = f"{gdb.selected_inferior().pid}.{gdb.selected_thread().ptid[1]}"
>> >+
>> >+    # Create a new filter for new threads.
>> >+    if key not in _ptwrite_filter.keys():
>> >+        _ptwrite_filter[key] = deepcopy(_ptwrite_filter["global"])
>>
>> Do we even need this "global" filter in the dict?  Could we just use the
>> default_filter, here?
>
>I don't see how. In case a custom filter is registered and
>a new thread spawns, we need "global". We can't copy default_filter and
>we can't copy from other threads, as they might have internal state already.

That was the question whether we could copy default_filter.

regards,
markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928