public inbox for
 help / color / mirror / Atom feed
From: Tom Tromey <>
To: Aaron Merey via Gdb-patches <>
Cc: Aaron Merey <>
Subject: Re: [PATCH] gdb/linespec.c: Fix missing source file during breakpoint re-set.
Date: Mon, 09 Jan 2023 12:27:05 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Aaron Merey via Gdb-patches's message of "Wed, 12 Oct 2022 16:49:16 -0400")

>>>>> "Aaron" == Aaron Merey via Gdb-patches <> writes:

Aaron> I'm reposting this patch with a testcase added to
Aaron> testsuite/gdb.debuginfod/fetch_src_and_symbols.exp.  I tried finding a
Aaron> way to reproduce the error without debuginfod by using 'set
Aaron> substitute-path' but the substitution rules always converted the symtab
Aaron> fullname to the filename which avoided the error.  Since I don't know
Aaron> of any other way to trigger the error other than with source files
Aaron> downloaded from debuginfod, the gdb.debuginfod seems like the best (only?)
Aaron> place for the test.

Sorry about the long delay on this.

It's pretty hard to review a patch like this, since it's hard to know
what impact it might have.  However I am mostly fine with it (see the
end), assuming you regression-tested it.

Aaron> +    gdb_test "run" "Breakpoint 1,.*" \
Aaron> +	"file [file tail $binfile] set breakpoint]"
I think there's an unmatched "]" here.


      parent reply	other threads:[~2023-01-09 19:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 23:44 Aaron Merey
2022-10-10 16:06 ` Bruno Larsen
2022-10-12 20:49 ` Aaron Merey
2022-10-13  7:59   ` Bruno Larsen
2022-10-14  0:47     ` Aaron Merey
2022-10-21 17:07       ` Aaron Merey
2023-01-06 23:56         ` [PING*2][PATCH] " Aaron Merey
2023-01-09 19:27           ` Tom Tromey
2023-01-10  1:15             ` Aaron Merey
2023-02-01 17:37           ` Andrew Burgess
2023-01-09 19:27   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).