From: Aaron Merey <amerey@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PING*2][PATCH] gdb/linespec.c: Fix missing source file during breakpoint re-set
Date: Mon, 9 Jan 2023 20:15:49 -0500 [thread overview]
Message-ID: <CAJDtP-R+rGHWQtcO6ZZEdH6rNr57zg7pGGLCo2B1WgMLb=vXFA@mail.gmail.com> (raw)
In-Reply-To: <87y1qb8q4m.fsf@tromey.com>
On Mon, Jan 9, 2023 at 2:28 PM Tom Tromey <tom@tromey.com> wrote:
> Oops, I reviewed the wrong version.
> This one is ok. Thank you.
Thanks Tom, pushed as commit 7dd38e31d67.
On Mon, Jan 9, 2023 at 2:27 PM Tom Tromey <tom@tromey.com> wrote:
> It's pretty hard to review a patch like this, since it's hard to know
> what impact it might have. However I am mostly fine with it (see the
> end), assuming you regression-tested it.
Regression tested on x86_64 F36 and F37.
Aaron
next prev parent reply other threads:[~2023-01-10 1:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 23:44 [PATCH] " Aaron Merey
2022-10-10 16:06 ` Bruno Larsen
2022-10-12 20:49 ` Aaron Merey
2022-10-13 7:59 ` Bruno Larsen
2022-10-14 0:47 ` Aaron Merey
2022-10-21 17:07 ` Aaron Merey
2023-01-06 23:56 ` [PING*2][PATCH] " Aaron Merey
2023-01-09 19:27 ` Tom Tromey
2023-01-10 1:15 ` Aaron Merey [this message]
2023-02-01 17:37 ` Andrew Burgess
2023-01-09 19:27 ` [PATCH] " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJDtP-R+rGHWQtcO6ZZEdH6rNr57zg7pGGLCo2B1WgMLb=vXFA@mail.gmail.com' \
--to=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).