From: Tom Tromey <tom@tromey.com>
To: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
Cc: tom@tromey.com, Aaron Merey <amerey@redhat.com>,
aburgess@redhat.com, lsix@lancelot.com
Subject: Re: [PATCH 2/2] PR gdb/27570: missing support for debuginfod in core_target::build_file_mappings
Date: Fri, 11 Mar 2022 08:27:21 -0700 [thread overview]
Message-ID: <8735jomrvq.fsf@tromey.com> (raw)
In-Reply-To: <20220308003331.171162-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Mon, 7 Mar 2022 19:33:31 -0500")
>>>>> Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:
> gdb/corelow.c | 28 ++++++++++
> gdb/debuginfod-support.c | 51 +++++++++++++++++++
> gdb/debuginfod-support.h | 17 +++++++
> gdb/gcore.in | 2 +-
> gdb/solib.c | 32 ++++++++++++
> .../gdb.debuginfod/fetch_src_and_symbols.exp | 22 ++++++++
> 6 files changed, 151 insertions(+), 1 deletion(-)
This looks good to me. Thanks.
> + if (debuginfod_verbose > 0 && fd.get () < 0 && fd.get () != -ENOENT)
> + printf_filtered (_("Download failed: %s. " \
> + "Continuing without executable for %ps.\n"),
> + safe_strerror (-fd.get ()),
> + styled_string (file_name_style.style (), filename));
I can't remember if I mentioned this before but it seems like a failure
to download should probably always be reported. Maybe this ought to be
an unconditional warning call.
Tom
next prev parent reply other threads:[~2022-03-11 15:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 1:34 [PATCH 0/2] Add debuginfod core file support Aaron Merey
2022-03-03 1:35 ` [PATCH 1/2] gdb: Add soname to build-id mapping for core files Aaron Merey
2022-03-04 14:53 ` Tom Tromey
2022-03-08 0:30 ` Aaron Merey
2022-03-11 15:23 ` Tom Tromey
2022-03-11 21:44 ` Aaron Merey
2022-03-18 19:03 ` Tom Tromey
2022-03-21 18:21 ` Aaron Merey
2022-03-03 1:35 ` [PATCH 2/2] PR gdb/27570: missing support for debuginfod in core_target::build_file_mappings Aaron Merey
2022-03-04 15:20 ` Tom Tromey
2022-03-08 0:33 ` Aaron Merey
2022-03-11 15:27 ` Tom Tromey [this message]
2022-03-11 21:49 ` Aaron Merey
2022-03-21 18:22 ` Aaron Merey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735jomrvq.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).