Re: [PATCH 1/2] gdb: Add soname to build-id mapping for core files

[Tom Tromey <tom@tromey.com>]

>>>>> Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:

Hi again.

> +	    if (soname.get () != nullptr)

I don't think you need the .get here.

> +  std::unordered_map<char *, const bfd_build_id *> filename_map;

I suspect this code is intended to use the contents of the string as the
key -- but this will actually use the pointer value as the key.

If the pointer value is intended, some comment somewhere to that effect
-- explaining why it's an ok approach -- would be good to have.

> +      if (sec->flags & SEC_LOAD
> +	  && get_elf_backend_data (cbfd)->elf_backend_core_find_build_id
> +	       (cbfd, (bfd_vma) sec->filepos))

The get_elf_backend_data call has to have parens around it according to
GNU / gdb style.

> +  /* Read the soname from the string table.  */
> +  gdb::byte_vector dynstr_buf;
> +  if (!gdb_bfd_get_full_section_contents (abfd.get (), dynstr, &dynstr_buf))
> +    return {};
> +
> +  return make_unique_xstrdup ((char *) dynstr_buf.data () + idx);

What if the data isn't \0-terminated?  Maybe some size checking (not
sure if needed) and make_unique_xstrndup would be safer.

Tom