Re: [PATCH 2/2] PR gdb/27570: missing support for debuginfod in core_target::build_file_mappings

[Tom Tromey <tom@tromey.com>]

>>>>> "Aaron" == Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:

Aaron> When core file shared libraries are found locally, verify that their
Aaron> build-ids match the corresponding build-ids found in the core file.
Aaron> If there is a mismatch, attempt to query debuginfod for the correct
Aaron> build and print a warning if unsuccessful:

Aaron>   warning: Build-id of /lib64/libc.so.6 does not match core file.

Nice.

Aaron> +	  if (execbfd == nullptr)
Aaron> +	    warning (_("File \"%s\" from debuginfod cannot be opened as bfd"),
Aaron> +		     execpath.get ());

I suspect this should use gdb_bfd_errmsg.

Aaron> +  char *dname = nullptr;

Aaron> +  scoped_fd fd (debuginfod_find_executable (c, build_id, build_id_len, &dname));
Aaron> +  debuginfod_set_user_data (c, nullptr);

Aaron> +  if (fd.get () >= 0)
Aaron> +    destname->reset (dname);

Is it possible for fd.get()<0 and dname!=nullptr?  If so there's a
memory leak.

Aaron> +  gdb::unique_xmalloc_ptr<char> build_id_hexstr =
Aaron> +    get_cbfd_soname_build_id (current_program_space->cbfd, so->so_name);

'=' on the next line.

Tom