Re: [PATCH 2/2] PR gdb/27570: missing support for debuginfod in core_target::build_file_mappings

[Aaron Merey <amerey@redhat.com>]

On Fri, Mar 11, 2022 at 10:27 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> >  gdb/corelow.c                                 | 28 ++++++++++
> >  gdb/debuginfod-support.c                      | 51 +++++++++++++++++++
> >  gdb/debuginfod-support.h                      | 17 +++++++
> >  gdb/gcore.in                                  |  2 +-
> >  gdb/solib.c                                   | 32 ++++++++++++
> >  .../gdb.debuginfod/fetch_src_and_symbols.exp  | 22 ++++++++
> >  6 files changed, 151 insertions(+), 1 deletion(-)
>
> This looks good to me.  Thanks.

Great, I'll merge it once patch 1/2 is merged.

>
> > +  if (debuginfod_verbose > 0 && fd.get () < 0 && fd.get () != -ENOENT)
> > +    printf_filtered (_("Download failed: %s. " \
> > +                    "Continuing without executable for %ps.\n"),
> > +                  safe_strerror (-fd.get ()),
> > +                  styled_string (file_name_style.style (),  filename));
>
> I can't remember if I mentioned this before but it seems like a failure
> to download should probably always be reported.  Maybe this ought to be
> an unconditional warning call.

I will fix this in a separate patch. I think this counts as an obvious fix.

Aaron