Re: [PATCH] Do not record a rejected target description

[Tom Tromey <tromey@adacore.com>]

>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> When connecting to a certain target, gdb issues a warning about the
Tom> target description:

Tom>     (gdb) target remote localhost:7947
Tom>     Remote debugging using localhost:7947
Tom>     warning: Architecture rejected target-supplied description

Tom> If you then kill the inferior and change the exec-file, this will
Tom> happen:

Tom>     (gdb) file bar
Tom>     Architecture of file not recognized.

Tom> After this, debugging doesn't work very well.

Tom> What happens here is that, despite the warning,
Tom> target_find_description records the downloaded description in the
Tom> target_desc_info.  Then the "file" command ends up calling
Tom> set_gdbarch_from_file, which uses that description.

Tom> It seems to me that, because the architecture rejected the
Tom> description, it should not be used.  That is what this patch
Tom> implements.

We've been using this internally with our misbehaving target and it is
fine, but I'd appreciate someone else's review.

thanks,
Tom