From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tromey@adacore.com>
Cc: Tom Tromey <tromey@adacore.com>, Simon Marchi <simark@simark.ca>,
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Do not record a rejected target description
Date: Fri, 17 Feb 2023 22:29:40 +0000 [thread overview]
Message-ID: <87h6vkkjsb.fsf@redhat.com> (raw)
In-Reply-To: <87pma8o031.fsf@tromey.com>
Tom Tromey <tromey@adacore.com> writes:
>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
>>> -# Required registers are not present so it is expected a warning.
>>> -#
>>> -gdb_test "set tdesc filename $srcdir/$subdir/maint_print_struct.xml" "
>>> -warning:.*" "setting a new tdesc having only a structure"
>
> Andrew> Haven't you just deleted a test for a warning here?
>
> I thought it was just incidental. I looked at the history of the file
> and the original commit message only discusses handling the "struct"
> case.
>
> Andrew> I'd propose the patch below.
>
> Looks good to me, thanks.
> Approved-By: Tom Tromey <tromey@adacore.com>
Pushed.
Thanks,
Andrew
prev parent reply other threads:[~2023-02-17 22:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 19:33 Tom Tromey
2023-02-14 15:16 ` Tom Tromey
2023-02-14 15:48 ` Andrew Burgess
2023-02-14 17:27 ` Tom Tromey
2023-02-15 12:56 ` Andrew Burgess
2023-02-15 15:59 ` Tom Tromey
2023-02-15 21:19 ` Simon Marchi
2023-02-15 21:38 ` Tom Tromey
2023-02-16 19:20 ` Tom Tromey
2023-02-16 19:33 ` Simon Marchi
2023-02-17 10:19 ` Andrew Burgess
2023-02-17 14:09 ` Tom Tromey
2023-02-17 22:29 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6vkkjsb.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).