Re: [PATCH] Do not record a rejected target description

[Tom Tromey <tromey@adacore.com>]

Simon> I see:

Simon>   maint print c-tdesc^M
Simon>   There is no target description to print.^M
Simon>   (gdb) FAIL: gdb.xml/maint_print_struct.exp: printing tdesc with a structure and a bitfield

Here's a patch that avoids this problem.
Let me know what you think.

Tom

commit a12897d22ccc1d927960fa411b99723d76620af0
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Feb 16 12:17:50 2023 -0700

    Fix regression in maint_print_struct.exp
    
    An earlier patch of mine caused a regression in
    maint_print_struct.exp.  This patch fixes it by modifying the test so
    that it does not rely on the erroneous target description being
    available.

diff --git a/gdb/testsuite/gdb.xml/maint_print_struct.exp b/gdb/testsuite/gdb.xml/maint_print_struct.exp
index 6f411895501..5b7c1489d3e 100644
--- a/gdb/testsuite/gdb.xml/maint_print_struct.exp
+++ b/gdb/testsuite/gdb.xml/maint_print_struct.exp
@@ -21,12 +21,7 @@ require allow_xml_test
 
 gdb_start
 
-# Required registers are not present so it is expected a warning.
-#
-gdb_test "set tdesc filename $srcdir/$subdir/maint_print_struct.xml" "
-warning:.*" "setting a new tdesc having only a structure"
-
-gdb_test "maint print c-tdesc" "
+gdb_test "maint print c-tdesc $srcdir/$subdir/maint_print_struct.xml" "
 .*tdesc_create_reg \\(feature, \"bad_reg1\", \[0-9\]+, 1, NULL, 128, \"two_fielded\"\\);\r
 .*tdesc_create_reg \\(feature, \"bad_reg2\", \[0-9\]+, 1, NULL, 64, \"bitfield\"\\);\r
 .*" "printing tdesc with a structure and a bitfield"