From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: Andrew Burgess <aburgess@redhat.com>,
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Do not record a rejected target description
Date: Thu, 16 Feb 2023 14:33:01 -0500 [thread overview]
Message-ID: <96fb5549-ed77-2eda-8368-c3f7b4e087f8@simark.ca> (raw)
In-Reply-To: <87zg9do1s6.fsf@tromey.com>
On 2/16/23 14:20, Tom Tromey wrote:
> Simon> I see:
>
> Simon> maint print c-tdesc^M
> Simon> There is no target description to print.^M
> Simon> (gdb) FAIL: gdb.xml/maint_print_struct.exp: printing tdesc with a structure and a bitfield
>
> Here's a patch that avoids this problem.
> Let me know what you think.
>
> Tom
>
> commit a12897d22ccc1d927960fa411b99723d76620af0
> Author: Tom Tromey <tromey@adacore.com>
> Date: Thu Feb 16 12:17:50 2023 -0700
>
> Fix regression in maint_print_struct.exp
>
> An earlier patch of mine caused a regression in
> maint_print_struct.exp. This patch fixes it by modifying the test so
> that it does not rely on the erroneous target description being
> available.
I don't have time to dig in the implementation to review, but I
confirmed it fixes the problem on my side, so:
Tested-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2023-02-16 19:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 19:33 Tom Tromey
2023-02-14 15:16 ` Tom Tromey
2023-02-14 15:48 ` Andrew Burgess
2023-02-14 17:27 ` Tom Tromey
2023-02-15 12:56 ` Andrew Burgess
2023-02-15 15:59 ` Tom Tromey
2023-02-15 21:19 ` Simon Marchi
2023-02-15 21:38 ` Tom Tromey
2023-02-16 19:20 ` Tom Tromey
2023-02-16 19:33 ` Simon Marchi [this message]
2023-02-17 10:19 ` Andrew Burgess
2023-02-17 14:09 ` Tom Tromey
2023-02-17 22:29 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96fb5549-ed77-2eda-8368-c3f7b4e087f8@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).