public inbox for
 help / color / mirror / Atom feed
From: Tom Tromey <>
To: Aaron Merey <>
Cc: Tom Tromey <>,
	 Aaron Merey via Gdb-patches <>
Subject: Re: [PATCH] gdb/debuginfod: Prevent prompt for continue during downloading.
Date: Wed, 08 Feb 2023 07:44:14 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Aaron Merey's message of "Tue, 31 Jan 2023 15:41:45 -0500")

>>>>> "Aaron" == Aaron Merey <> writes:

Aaron> Setting pagination_enabled to false does stop the prompt in this case,
Aaron> however during testing of the on-demand downloading feature that I'm
Aaron> working on [1] I saw cases where this still didn't prevent the prompt.

>> If clearing pagination_enabled results in paging, then that sounds like
>> a serious bug.  Looking at the code I don't see how it can happen.
>> Could you track it down?

Aaron> Sure I'll take a look at it.

It occurred to me last night that this could be a subtle change
introduced by the pager rewrite.

Before, disabling pagination also disabled line splitting, and took an
earlier exit.

But now, if pagination is disabled for some output, those lines still
"count" towards the total.  So then when pagination is no longer
disabled, a print might cause the pager to intervene.

Is this what's happening in your case?  If so, I'm not totally sure it
is a bug.  Normally disabling paging should be done because using the
pager isn't safe or appropriate at some point in time.  But having those
lines still "count" seems alright, maybe even useful.


  reply	other threads:[~2023-02-08 14:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-28  4:06 Aaron Merey
2023-01-28 15:01 ` Tom Tromey
2023-01-31  2:09   ` Aaron Merey
2023-01-31 14:22     ` Tom Tromey
2023-01-31 20:41       ` Aaron Merey
2023-02-08 14:44         ` Tom Tromey [this message]
2023-02-11  2:02           ` Aaron Merey
2023-02-13 14:17             ` Tom Tromey
2023-02-13 20:23               ` Aaron Merey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).