Re: [PATCH] gdb/debuginfod: Prevent prompt for continue during downloading.

[Tom Tromey <tom@tromey.com>]

>>>>> "Aaron" == Aaron Merey <amerey@redhat.com> writes:

Aaron> Setting pagination_enabled to false does stop the prompt in this case,
Aaron> however during testing of the on-demand downloading feature that I'm
Aaron> working on [1] I saw cases where this still didn't prevent the prompt.

>> If clearing pagination_enabled results in paging, then that sounds like
>> a serious bug.  Looking at the code I don't see how it can happen.
>> Could you track it down?

Aaron> Sure I'll take a look at it.

It occurred to me last night that this could be a subtle change
introduced by the pager rewrite.

Before, disabling pagination also disabled line splitting, and took an
earlier exit.

But now, if pagination is disabled for some output, those lines still
"count" towards the total.  So then when pagination is no longer
disabled, a print might cause the pager to intervene.

Is this what's happening in your case?  If so, I'm not totally sure it
is a bug.  Normally disabling paging should be done because using the
pager isn't safe or appropriate at some point in time.  But having those
lines still "count" seems alright, maybe even useful.

Tom