[PATCH] Add type to expression dump of symbol

[PATCH] Add type to expression dump of symbol

[Tom Tromey]

I recently had cause to dump some expressions from gdb.  I got output
like this:

 Operation: BINOP_GTR
  Operation: OP_VAR_VALUE
   Block symbol:
    Symbol: small_value
    Block: 0x39b4c20
  Operation: OP_LONG
   Operation: OP_LONG
    Type: int
    Constant: 0x0000000000000014

This is ok, but it would have been handy to see the type of the
symbol.  This ptach adds this information.
---
 gdb/expprint.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/expprint.c b/gdb/expprint.c
index a873cf8df74..11aeed4b6f7 100644
--- a/gdb/expprint.c
+++ b/gdb/expprint.c
@@ -114,6 +114,7 @@ dump_for_expression (struct ui_file *stream, int depth, symbol *sym)
 {
   gdb_printf (stream, _("%*sSymbol: %s\n"), depth, "",
 	      sym->print_name ());
+  dump_for_expression (stream, depth + 1, sym->type ());
 }
 
 void
-- 
2.38.1

Re: [PATCH] Add type to expression dump of symbol

[Bruno Larsen]

On 02/01/2023 18:28, Tom Tromey via Gdb-patches wrote:
> I recently had cause to dump some expressions from gdb.  I got output
> like this:
>
>   Operation: BINOP_GTR
>    Operation: OP_VAR_VALUE
>     Block symbol:
>      Symbol: small_value
>      Block: 0x39b4c20
>    Operation: OP_LONG
>     Operation: OP_LONG
>      Type: int
>      Constant: 0x0000000000000014
>
> This is ok, but it would have been handy to see the type of the
> symbol.  This ptach adds this information.

s/ptach/patch

Other than that, seems useful and introduces no regressions, so

Reviewed-By: Bruno Larsen <blarsen@redhat.com>

-- 
Cheers,
Bruno

Re: [PATCH] Add type to expression dump of symbol

[Tom Tromey]

>> This is ok, but it would have been handy to see the type of the
>> symbol.  This ptach adds this information.

Bruno> s/ptach/patch

Thanks, I fixed that.

Bruno> Other than that, seems useful and introduces no regressions, so

Bruno> Reviewed-By: Bruno Larsen <blarsen@redhat.com>

Thanks again.  I'm checking this in.

Tom