[PATCH 1/1] gdb, i386: Update stale comment in i386-tdep.h.

[PATCH 1/1] gdb, i386: Update stale comment in i386-tdep.h.

[Felix Willgerodt]

The comment seems no longer valid, the functions technically check for
non-pseudo registers, like zmmh.  Which is a valid use case.

This could also be considered obvious, but the 32-bit register code is
a bit complex to understand.
---
 gdb/i386-tdep.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/i386-tdep.h b/gdb/i386-tdep.h
index 82de5faa988..371bce72369 100644
--- a/gdb/i386-tdep.h
+++ b/gdb/i386-tdep.h
@@ -353,7 +353,7 @@ enum record_i386_regnum
 /* Types for i386-specific registers.  */
 extern struct type *i387_ext_type (struct gdbarch *gdbarch);
 
-/* Checks of different pseudo-registers.  */
+/* Checks of different registers.  */
 extern int i386_byte_regnum_p (struct gdbarch *gdbarch, int regnum);
 extern int i386_word_regnum_p (struct gdbarch *gdbarch, int regnum);
 extern int i386_dword_regnum_p (struct gdbarch *gdbarch, int regnum);
-- 
2.34.3

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [PATCH 1/1] gdb, i386: Update stale comment in i386-tdep.h.

[Tom Tromey]

>>>>> "Felix" == Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org> writes:

Felix> The comment seems no longer valid, the functions technically check for
Felix> non-pseudo registers, like zmmh.  Which is a valid use case.

Felix> This could also be considered obvious, but the 32-bit register code is
Felix> a bit complex to understand.

It seems fine to me.  Thank you.

Tom

RE: [PATCH 1/1] gdb, i386: Update stale comment in i386-tdep.h.

[Willgerodt, Felix]

Pushed.

Thanks,
Felix

> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Dienstag, 24. Januar 2023 19:44
> To: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
> Subject: Re: [PATCH 1/1] gdb, i386: Update stale comment in i386-tdep.h.
> 
> >>>>> "Felix" == Felix Willgerodt via Gdb-patches <gdb-
> patches@sourceware.org> writes:
> 
> Felix> The comment seems no longer valid, the functions technically check
> for
> Felix> non-pseudo registers, like zmmh.  Which is a valid use case.
> 
> Felix> This could also be considered obvious, but the 32-bit register code is
> Felix> a bit complex to understand.
> 
> It seems fine to me.  Thank you.
> 
> Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928