public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luis.machado@arm.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] info breakpoints improvements
Date: Tue, 24 May 2022 15:09:30 +0100	[thread overview]
Message-ID: <9cddada4-6572-7bb2-736e-3662097be07e@palves.net> (raw)
In-Reply-To: <83bkvn58pe.fsf@gnu.org>

On 2022-05-24 15:03, Eli Zaretskii wrote:
>> Date: Tue, 24 May 2022 14:50:01 +0100
>> Cc: luis.machado@arm.com, gdb-patches@sourceware.org
>> From: Pedro Alves <pedro@palves.net>
>>
>>>> A location only breaks if it is enabled, _and_ its parent is enabled, so never.
>>>
>>> That's what I thought.  But then why not "propagate" the "n" of the
>>> disabled breakpoint to all of its locations?  
>>
>> Because then when you re-enable the parent breakpoint, you'd have lost the enabled/disabled
>> state of the individual locations.
> 
> I don't understand why would that be lost.  I'm not proposing to
> actually disable each location, I propose to _display_ them as
> disabled in that case.

If you do that, then you're hiding information for no good reason, IMO.  It makes
it confusing, one would no longer be able to tell which locations would be enabled
once you re-enable the parent breakpoint.  You'd make "enable 3.2" seem to have
no effect on a disabled breakpoint, as "info break" would still show the location
as disabled.

> 
>>>   (gdb) info break 4.10
>>>
>>> will show the truth, no?
>>
>> You can't "info break" an individual location.
> 
> And you are certain we never will support that?

Of course not, but as usual, we can cross that bridge when to come to it.  I suspect
that if we did support that, we would still want to print the breakpoint row for
breakpoint 4 and then only location 10 (skipping all other locations), so you'd still
see the breakpoint's enable state, and other info.

  reply	other threads:[~2022-05-24 14:09 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 21:55 Pedro Alves
2022-05-19 21:55 ` [PATCH 1/2] Always show locations for breakpoints & show canonical location spec Pedro Alves
2022-05-20  6:45   ` Eli Zaretskii
2022-05-23 17:04     ` [PATCH v2 " Pedro Alves
2022-05-24 13:06       ` Eli Zaretskii
2022-05-25 19:32         ` Pedro Alves
2022-05-26 12:48           ` Eli Zaretskii
2022-05-26 14:04             ` Pedro Alves
2022-05-26 15:03               ` Eli Zaretskii
2022-05-26 15:10                 ` Pedro Alves
2022-05-26 15:33                   ` Eli Zaretskii
2022-05-26 19:29                 ` Pedro Alves
2022-05-26 19:55                   ` Eli Zaretskii
2022-05-26 20:40                     ` Pedro Alves
2023-04-10 15:07                   ` Andrew Burgess
2022-05-20  7:45   ` [PATCH " Metzger, Markus T
2022-05-23 17:05     ` Lancelot SIX
2022-05-19 21:55 ` [PATCH 2/2] Introduce "info breakpoints -hide-locations" Pedro Alves
2022-05-20  6:48   ` Eli Zaretskii
2022-05-20  5:57 ` [PATCH 0/2] info breakpoints improvements Eli Zaretskii
2022-05-23 17:06   ` Pedro Alves
2022-05-24 13:14     ` Eli Zaretskii
2022-05-24 13:45       ` Pedro Alves
2022-05-24  8:38 ` Luis Machado
2022-05-24 10:02   ` Pedro Alves
2022-05-24 13:20     ` Eli Zaretskii
2022-05-24 13:29       ` Pedro Alves
2022-05-24 13:43         ` Eli Zaretskii
2022-05-24 13:50           ` Pedro Alves
2022-05-24 14:03             ` Eli Zaretskii
2022-05-24 14:09               ` Pedro Alves [this message]
2022-05-24 14:25                 ` Eli Zaretskii
2022-05-24 14:33                   ` Pedro Alves
2022-05-24 14:11               ` Andreas Schwab
2022-05-24 14:17                 ` Pedro Alves
2022-05-24 19:49                   ` [PATCH] Show enabled locations with disabled breakpoint parent as "y-" (Re: [PATCH 0/2] info breakpoints improvements) Pedro Alves
2022-05-25 13:57                     ` Eli Zaretskii
2022-05-25 19:19                       ` Pedro Alves
2022-05-24 14:26                 ` [PATCH 0/2] info breakpoints improvements Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cddada4-6572-7bb2-736e-3662097be07e@palves.net \
    --to=pedro@palves.net \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).