Re: [PATCH 0/2] info breakpoints improvements

[Luis Machado <luis.machado@arm.com>]

On 5/19/22 22:55, Pedro Alves wrote:
> The subject of breakpoint line number sliding came up again in an
> internal discussion, which reminded me of this WIP patch that I
> originally posted here:
> https://sourceware.org/pipermail/gdb-patches/2019-June/158638.html
> 
> Here's an updated version that is close to ready for merging.  It
> needs agreement, and, testsuite adjustments.  Oh, and I realize now,
> NEWS entries.  Both patches already contain documentation changes.  I
> went through the whole "Set Breaks" chapter fixing up things to better
> match current reality as I was documenting the new features.
> 
> Patch #1 changes GDB such that instead of:
> 
>   (top-gdb) info breakpoints
>   1       breakpoint     keep y   0x0000000000575127 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54
>   2       breakpoint     keep y   0x0000000000575127 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54
>   3       breakpoint     keep y   <MULTIPLE>
>   3.1                         y   0x0000000000575127 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54
>   3.2                         y   0x00007ffff6d50410 in PyErr_SetObject at /usr/src/debug/python2-2.7.15-4.fc27.x86_64/Python/errors.c:54
>   4       breakpoint     keep y   0x000055555564107b in main(int, char**) at src/gdb/gdb.c:28
>   (top-gdb)
> 
> we get:
> 
>   (top-gdb) info breakpoints
>   Num     Type           Disp Enb Address            What
>   1       breakpoint     keep y                      internal_error
>    1.1                        y   0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54
>   2       breakpoint     keep y                      -qualified internal_error
>    2.1                        y   0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54
>   3       breakpoint     keep y                      errors.c:54
>    3.1                        y   0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54
>    3.2                        y   0x00007ffff6d50410 in PyErr_SetObject at /usr/src/debug/python2-2.7.15-4.fc27.x86_64/Python/errors.c:54
>   4       breakpoint     keep y                      gdb.c:27
>    4.1                        y   0x000055555564107b in main(int, char**) at src/gdb/gdb.c:28
>   (top-gdb)
> 

The additional information is nice to have, though I don't use it myself and I'm happy with <MULTIPLE> and the
fact GDB adjusts line numbers (it's just natural). Maybe others not familiar with DWARF and line tables will find it
useful. Maybe even IDE's dealing with GDB.

I could make a point that the patch makes things slightly more verbose, but the breakpoint display is already quite verbose. :-)

So overall it looks like a good direction to go.

I anticipate a lot of tedious changes to the testsuite due to changing patterns.