RE: [PATCH 1/2] Always show locations for breakpoints & show canonical location spec

["Metzger, Markus T" <markus.t.metzger@intel.com>]

Hello Pedro,

> (top-gdb) info breakpoints
> Num     Type           Disp Enb Address            What
> 1       breakpoint     keep y                      internal_error
> 1.1                         y   0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54
> 2       breakpoint     keep y                      -qualified internal_error
> 2.1                         y   0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54
> 3       breakpoint     keep y                      errors.c:54
> 3.1                         y   0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54
> 3.2                         y   0x00007ffff6d50410 in PyErr_SetObject at /usr/src/debug/python2-2.7.15-4.fc27.x86_64/Python/errors.c:54

This change looks very nice to me.  It will be very helpful once GDB starts
sliding breakpoints per function and we end up with different source lines
for different instances.

I wouldn't indent the breakpoint instances, though.  There is already visual
feedback in the longer breakpoint numbers and the fact that 'type' and 'disp'
are omitted to separate the groups.

regards,
markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928