Re: [PATCH 2/5] sim: Factor out NaN handling in floating point operations

[Mike Frysinger <vapier@gentoo.org>]

On 20 May 2021 13:15, Faraz Shahbazker wrote:
> --- a/sim/common/sim-fpu.c
> +++ b/sim/common/sim-fpu.c
>  
> +/* NaN handling for binary operations.  */
>  
> +INLINE_SIM_FPU (int)
> +sim_fpu_op_nan (sim_fpu *f, const sim_fpu *l, const sim_fpu *r)
> +{
> +  if (sim_fpu_is_snan (l) || sim_fpu_is_snan (r))
> +    {
> +      *f = sim_fpu_is_snan (l) ? *l : *r;
> +      f->class = sim_fpu_class_qnan;
> +      return sim_fpu_status_invalid_snan;
> +    }
> +   ASSERT (sim_fpu_is_nan (l) || sim_fpu_is_nan (r));

indent style of this func needs fixing as it's all over the place

> +   if (sim_fpu_is_qnan (l))
> +	*f = *l;
> +   else /* if (sim_fpu_is_qnan (r)) */
> +    *f = *r;

so some of the logic you replaced below do:
	if (sim_fpu_is_qnan (l))
	  {
	    *f = *l;
	    return 0;
	  }
	if (sim_fpu_is_qnan (r))
	  {
	    *f = *r;
	    return 0;
	  }

but others do:
	if (sim_fpu_is_qnan (l))
	  {
	    *f = *l;
	    f->class = sim_fpu_class_qnan;
	    return 0;
	  }
	if (sim_fpu_is_qnan (r))
	  {
	    *f = *r;
	    f->class = sim_fpu_class_qnan;
	    return 0;
	  }

it seems like we should have been consistently doing the latter ?
so it's a good time to fix with your new helper.

> +    return sim_fpu_op_nan (f, l, r);x

looks like you have a typo in there.  might want to do a compile test.
-mike