Re: [PATCH v2 1/3] [sim/riscv] Add basic semi-hosting support

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]

On 30 Oct 2023 13:00, jaydeep.patil@imgtec.com wrote:
> Added support for basic semi-hosting calls OPEN, EXIT and GET_CMDLINE.

what host environment are you implementing ?  none of the syscalls you've
defined match what have long been in the riscv libgloss port.  those are
the only ones i'd really expect at this point to be wired up.

> Added gdb.arch/riscv-exit-getcmd.c to test it.
> ---
>  gdb/testsuite/gdb.arch/riscv-exit-getcmd.c   |  26 +++
>  gdb/testsuite/gdb.arch/riscv-exit-getcmd.exp |  27 +++
>  sim/riscv/riscv-sim.h                        |  32 +++
>  sim/riscv/sim-main.c                         | 230 ++++++++++++++++++-

you're missing sim/ tests.  gdb tests are great, but not sufficient.

> @@ -990,6 +1209,7 @@ execute_one (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
>      case INSN_CLASS_A:
>        return execute_a (cpu, iw, op);
>      case INSN_CLASS_I:
> +    case INSN_CLASS_ZICSR:
>        return execute_i (cpu, iw, op);

seems unrelated to this patch
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]