Re: [PATCH] gdb/compile: Use std::filesystem::remove_all in cleanup

[Tom de Vries <tdevries@suse.de>]

On 3/8/24 17:27, Tom Tromey wrote:
>>>>>> "Lancelot" == Lancelot SIX <lancelot.six@amd.com> writes:
> 
> Lancelot> In a previous review, I noticed that some code in gdb/compile/compile.c
> Lancelot> could use c++17's `std::filesystem::remove_all` instead of using some
> Lancelot> `system ("rm -rf ...");`.
> 
> Lancelot> This patch implements this.
> 
> Lancelot> Note that I use the noexcept overload of std::filesystem::remove_all and
> Lancelot> explicitly check for an error code.  This means that this code called
> Lancelot> during the cleanup procedure cannot throw, and does not risk preventing
> Lancelot> other cleanup functions to be called.
> 
> Lancelot> Tested on x86_64-linux.
> 
> Lancelot> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31420
> Lancelot> Change-Id: If5668bf3e15e66c020e5c3b4fa999f861690e4cf
> 
> Thank you.  I think this is ok.
> 
> There might be some risk that there's a compiler that implements C++17
> but not std::filesystem.  If this happens I suppose we can either
> consider simply rejecting that compiler, or alternatively, revert this
> patch.

This broke the build for me with gcc 7.5.0, which apparently falls into 
the category of "mostly implements C++17 but not std::filesystem".

As we can see here ( https://gcc.gnu.org/gcc-8/changes.html#cxx ) 
support was added in gcc 8.

Thanks,
- Tom