public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: Andrew Pinski <pinskia@gmail.com>, Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>,
	gdb-patches@sourceware.org, lsix@lancelotsix.com
Subject: Re: [PATCH] gdb/compile: Use std::filesystem::remove_all in cleanup
Date: Thu, 4 Apr 2024 08:40:45 +0100	[thread overview]
Message-ID: <331746c9-ff55-4ae2-9677-b555275ed8b5@amd.com> (raw)
In-Reply-To: <CA+=Sn1m3xxgkrf1Qgd9fGa+OBsfXJn07vEe3ezzo8NMKfSyAkA@mail.gmail.com>

>> I wonder if there is a case for conditionally enabling this.  That would
>> ensure that the work is not lost, as well as used when using gcc >=8.
> 
> Let me add even though support was added for GCC 8, the functions are
> in included in libstdc++fs.a rather than the standard
> libstdc++.so/libstdc++.a.
> It was added to libstdc++ in GCC 9. So if you add this conditionally,
> you either need to do a feature test that does a link too or have one
> that adds libstdc++fs.a if not found in the standard library.
> 
> Thanks,
> Andrew
> 
Thanks for the input.

We did discuss briefly using "-libstdc++fs" on IRC, thanks for the 
precision regarding where it is required. As gcc-7.5 seems to still be 
used to build gdb, it looks like we will stay away from std::filesystem 
for now.

Thanks,
Lancelot.

      reply	other threads:[~2024-04-04  7:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-03 16:47 Lancelot SIX
2024-03-08 16:27 ` Tom Tromey
2024-04-03 12:56   ` Lancelot SIX
2024-04-03 14:37   ` Tom de Vries
2024-04-03 14:47     ` Lancelot SIX
2024-04-03 14:51       ` Tom de Vries
2024-04-03 17:08         ` Andrew Pinski
2024-04-04  7:40           ` Lancelot SIX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=331746c9-ff55-4ae2-9677-b555275ed8b5@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    --cc=pinskia@gmail.com \
    --cc=tdevries@suse.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).