Re: [PATCH] gdb/compile: Use std::filesystem::remove_all in cleanup

[Andrew Pinski <pinskia@gmail.com>]

On Wed, Apr 3, 2024 at 7:51 AM Tom de Vries <tdevries@suse.de> wrote:
>
> On 4/3/24 16:47, Lancelot SIX wrote:
> >>
> >> This broke the build for me with gcc 7.5.0, which apparently falls into
> >> the category of "mostly implements C++17 but not std::filesystem".
> >>
> >
> > Sorry about that, I have sent
> > https://sourceware.org/pipermail/gdb-patches/2024-April/207760.html to
> > revert that change.  At least, we know it is best to stay away from
> > std::filesystem for now.
> >
>
> I wonder if there is a case for conditionally enabling this.  That would
> ensure that the work is not lost, as well as used when using gcc >=8.

Let me add even though support was added for GCC 8, the functions are
in included in libstdc++fs.a rather than the standard
libstdc++.so/libstdc++.a.
It was added to libstdc++ in GCC 9. So if you add this conditionally,
you either need to do a feature test that does a link too or have one
that adds libstdc++fs.a if not found in the standard library.

Thanks,
Andrew

>
> Thanks,
> - Tom
>
>