From: Lancelot SIX <Lancelot.Six@amd.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, lsix@lancelotsix.com
Subject: Re: [PATCH] gdb/compile: Use std::filesystem::remove_all in cleanup
Date: Wed, 3 Apr 2024 13:56:48 +0100 [thread overview]
Message-ID: <36ffdc32-34e1-4ae0-851f-c50b49c938b8@amd.com> (raw)
In-Reply-To: <8734t0sn8d.fsf@tromey.com>
> Thank you. I think this is ok.
>
> There might be some risk that there's a compiler that implements C++17
> but not std::filesystem. If this happens I suppose we can either
> consider simply rejecting that compiler, or alternatively, revert this
> patch.
>
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
I have just pushed this patch. If it turns out that this causes any
issue for some configuration, I'll revert the patch.
Best,
Lancelot.
next prev parent reply other threads:[~2024-04-03 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 16:47 Lancelot SIX
2024-03-08 16:27 ` Tom Tromey
2024-04-03 12:56 ` Lancelot SIX [this message]
2024-04-03 14:37 ` Tom de Vries
2024-04-03 14:47 ` Lancelot SIX
2024-04-03 14:51 ` Tom de Vries
2024-04-03 17:08 ` Andrew Pinski
2024-04-04 7:40 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ffdc32-34e1-4ae0-851f-c50b49c938b8@amd.com \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).