From: Tom de Vries <tdevries@suse.de>
To: Lancelot SIX <Lancelot.Six@amd.com>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, lsix@lancelotsix.com
Subject: Re: [PATCH] gdb/compile: Use std::filesystem::remove_all in cleanup
Date: Wed, 3 Apr 2024 16:51:27 +0200 [thread overview]
Message-ID: <38c53217-76b5-4ec4-8235-3eb8ca021d2c@suse.de> (raw)
In-Reply-To: <6689da3c-9229-4338-9cad-b3bbeb1bbecf@amd.com>
On 4/3/24 16:47, Lancelot SIX wrote:
>>
>> This broke the build for me with gcc 7.5.0, which apparently falls into
>> the category of "mostly implements C++17 but not std::filesystem".
>>
>
> Sorry about that, I have sent
> https://sourceware.org/pipermail/gdb-patches/2024-April/207760.html to
> revert that change. At least, we know it is best to stay away from
> std::filesystem for now.
>
I wonder if there is a case for conditionally enabling this. That would
ensure that the work is not lost, as well as used when using gcc >=8.
Thanks,
- Tom
next prev parent reply other threads:[~2024-04-03 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 16:47 Lancelot SIX
2024-03-08 16:27 ` Tom Tromey
2024-04-03 12:56 ` Lancelot SIX
2024-04-03 14:37 ` Tom de Vries
2024-04-03 14:47 ` Lancelot SIX
2024-04-03 14:51 ` Tom de Vries [this message]
2024-04-03 17:08 ` Andrew Pinski
2024-04-04 7:40 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38c53217-76b5-4ec4-8235-3eb8ca021d2c@suse.de \
--to=tdevries@suse.de \
--cc=Lancelot.Six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).