A couple of trivial fixes

A couple of trivial fixes

[Reuben Thomas]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

I attach a couple of patches against master as of just now, one to fix the
English in a comment, and the other to remove gdb_select.h from
gdb/Makefile.in, as it has been moved to gdbsupport/ (this broke "make
tags").

-- 
https://rrt.sc3d.org

[-- Attachment #2: 0001-binutils-readelf.c-Fix-English-in-comment.patch --]
[-- Type: text/x-patch, Size: 948 bytes --]

From 1163b03a6569d63915a24fa12e3f2e0a30910672 Mon Sep 17 00:00:00 2001
From: Reuben Thomas <rrt@sc3d.org>
Date: Sat, 2 Jan 2021 11:48:09 +0000
Subject: [PATCH 1/2] binutils/readelf.c: Fix English in comment

---
 binutils/readelf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/binutils/readelf.c b/binutils/readelf.c
index d6e7a7b3835..ad16b4571c9 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -2609,7 +2609,7 @@ static void
 decode_ARC_machine_flags (unsigned e_flags, unsigned e_machine, char buf[])
 {
   /* ARC has two machine types EM_ARC_COMPACT and EM_ARC_COMPACT2.  Some
-     other compilers don't a specific architecture type in the e_flags, and
+     other compilers don't specify an architecture type in the e_flags, and
      instead use EM_ARC_COMPACT for old ARC600, ARC601, and ARC700
      architectures, and switch to EM_ARC_COMPACT2 for newer ARCEM and ARCHS
      architectures.
-- 
2.25.1


[-- Attachment #3: 0002-gdb-Makefile.in-remove-gdb_select.h-moved-to-gdbsupp.patch --]
[-- Type: text/x-patch, Size: 588 bytes --]

From a996b3e006d6e082b486d48bdbab51e018793c19 Mon Sep 17 00:00:00 2001
From: Reuben Thomas <rrt@sc3d.org>
Date: Sat, 2 Jan 2021 12:09:27 +0000
Subject: [PATCH 2/2] gdb/Makefile.in: remove gdb_select.h, moved to gdbsupport

---
 gdb/Makefile.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 9267bea7beb..3fdcb337cc4 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1298,7 +1298,6 @@ HFILES_NO_SRCDIR = \
 	gdb_obstack.h \
 	gdb_proc_service.h \
 	gdb_regex.h \
-	gdb_select.h \
 	gdb-stabs.h \
 	gdb_vfork.h \
 	gdb_wchar.h \
-- 
2.25.1

Re: A couple of trivial fixes

[Tom Tromey]

>>>>> "Reuben" == Reuben Thomas via Gdb-patches <gdb-patches@sourceware.org> writes:

Reuben> I attach a couple of patches against master as of just now, one to fix the
Reuben> English in a comment, and the other to remove gdb_select.h from
Reuben> gdb/Makefile.in, as it has been moved to gdbsupport/ (this broke "make
Reuben> tags").

Hi.  Thanks for the patches.

Before we can check them in, they both need ChangeLog entries.
See https://sourceware.org/gdb/wiki/ContributionChecklist

Reuben>  binutils/readelf.c | 2 +-

This one should go to the binutils list.

thanks,
Tom

Re: A couple of trivial fixes

[Reuben Thomas]

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

On Mon, 4 Jan 2021 at 19:33, Tom Tromey <tom@tromey.com> wrote:

> >>>>> "Reuben" == Reuben Thomas via Gdb-patches <
> gdb-patches@sourceware.org> writes:
>
> Reuben> I attach a couple of patches against master as of just now, one to
> fix the
> Reuben> English in a comment, and the other to remove gdb_select.h from
> Reuben> gdb/Makefile.in, as it has been moved to gdbsupport/ (this broke
> "make
> Reuben> tags").
>
> Hi.  Thanks for the patches.
>
> Before we can check them in, they both need ChangeLog entries.
>

Thanks, I've added a ChangeLog entry to the gdb patch and attach it here.

-- 
https://rrt.sc3d.org

[-- Attachment #2: 0002-gdb-Makefile.in-remove-gdb_select.h-moved-to-gdbsupp.patch --]
[-- Type: text/x-patch, Size: 979 bytes --]

From 2be4efd60a4d336f9852e9652951e4a19f432583 Mon Sep 17 00:00:00 2001
From: Reuben Thomas <rrt@sc3d.org>
Date: Sat, 2 Jan 2021 12:09:27 +0000
Subject: [PATCH 2/2] gdb/Makefile.in: remove gdb_select.h, moved to gdbsupport

---
 gdb/ChangeLog   | 4 ++++
 gdb/Makefile.in | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fb8c3c91878..fe438cfd25b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2021-01-06  Reuben Thomas  <rrt@sc3d.org>
+
+	* gdb/Makefile.in: remove gdb_select.h, moved to gdbsupport.
+
 2021-01-01  Joel Brobecker  <brobecker@adacore.com>
 
 	* gdbarch.sh: Update copyright year range.
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 9267bea7beb..3fdcb337cc4 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1298,7 +1298,6 @@ HFILES_NO_SRCDIR = \
 	gdb_obstack.h \
 	gdb_proc_service.h \
 	gdb_regex.h \
-	gdb_select.h \
 	gdb-stabs.h \
 	gdb_vfork.h \
 	gdb_wchar.h \
-- 
2.25.1

Re: A couple of trivial fixes

[Reuben Thomas]

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On Wed, 6 Jan 2021 at 21:46, Reuben Thomas <rrt@sc3d.org> wrote:

> On Mon, 4 Jan 2021 at 19:33, Tom Tromey <tom@tromey.com> wrote:
>
>> >>>>> "Reuben" == Reuben Thomas via Gdb-patches <
>> gdb-patches@sourceware.org> writes:
>>
>> Reuben> I attach a couple of patches against master as of just now, one
>> to fix the
>> Reuben> English in a comment, and the other to remove gdb_select.h from
>> Reuben> gdb/Makefile.in, as it has been moved to gdbsupport/ (this broke
>> "make
>> Reuben> tags").
>>
>> Hi.  Thanks for the patches.
>>
>> Before we can check them in, they both need ChangeLog entries.
>>
>
> Thanks, I've added a ChangeLog entry to the gdb patch and attach it here.
>

This patch was never applied to GDB as far as I can see, and it's still
needed.

I attach a revised version of the patch with no ChangeLog entry, since
these seem to have been discontinued.

-- 
https://rrt.sc3d.org

[-- Attachment #2: 0001-gdb-Makefile.in-remove-gdb_select.h-moved-to-gdbsupp.patch --]
[-- Type: text/x-patch, Size: 616 bytes --]

From f0080060d75228bee0ad288bf761001eb1726af6 Mon Sep 17 00:00:00 2001
From: Reuben Thomas <rrt@sc3d.org>
Date: Sat, 2 Jan 2021 12:09:27 +0000
Subject: [PATCH] gdb/Makefile.in: remove gdb_select.h, moved to gdbsupport

---
 gdb/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index aecab41eeb8..59712aeda49 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1321,7 +1321,7 @@ HFILES_NO_SRCDIR = \
 	gdb_curses.h \
 	gdb_expat.h \
 	gdb_proc_service.h \
-	gdb_select.h \
+	gdb_regex.h \
 	gdb-stabs.h \
 	gdb_vfork.h \
 	gdb_wchar.h \
-- 
2.25.1

[PATCHv2 0/3] Fix for 'make tags' build rule

[Andrew Burgess]

Hi Reuben,

Thanks for working on this, sorry your original patch didn't get
merged.

I took a look at your updated patch, and noticed what I think is a
merge issue with your update, you've removed gdb_select.h, but added
back in gdb_regex.h, I don't think this is intentional.

Anyway, I was going to fix that and push your patch, but first I
thought I'd test 'make tags' - and I noticed some additional problems.

The series below fixes these issues.

 #1 - this is a general clean up, and is not really related to 'make
      tags' at all,

 #2 - this is your patch, but with the merge issue mentioned above
      fixed.

 #3 - this fixes some additional warnings I was seeing from 'make
      tags'.

I'll give this some time for folk to comment before pushing.

Thanks for your work on this,

Andrew

---

Andrew Burgess (2):
  gdb/Makefile.in: remove SOURCES variable
  gdb/Makefile.in: move ALLDEPFILES earlier in Makefile.in

Reuben Thomas (1):
  gdb/Makefile.in: fix 'make tags' build target

 gdb/Makefile.in | 449 ++++++++++++++++++++++++------------------------
 1 file changed, 229 insertions(+), 220 deletions(-)

-- 
2.25.4

[PATCHv2 1/3] gdb/Makefile.in: remove SOURCES variable

[Andrew Burgess]

The SOURCES variable was added to gdb/Makefile.in as part of commit:

  commit fb40c20903110ed8af9701ce7c2635abd3770d52
  Date:   Wed Feb 23 00:25:43 2000 +0000

      Add mi/ and testsuite/gdb.mi/ subdirectories.

But as far as I can tell was not used at the time it was added, and is
not used today.

Lets remove it.
---
 gdb/Makefile.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index aecab41eeb8..009b733092d 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1590,7 +1590,6 @@ HFILES_WITH_SRCDIR = \
 
 DEPFILES = $(TARGET_OBS) $(SER_HARDWIRE) $(NATDEPFILES) $(SIM_OBS)
 
-SOURCES = $(SFILES) $(ALLDEPFILES) $(YYFILES) $(CONFIG_SRCS)
 # Don't include YYFILES (*.c) because we already include *.y in SFILES,
 # and it's more useful to see it in the .y file.
 TAGFILES_NO_SRCDIR = $(SFILES) $(HFILES_NO_SRCDIR) $(ALLDEPFILES) \
-- 
2.25.4

[PATCHv2 2/3] gdb/Makefile.in: fix 'make tags' build target

[Andrew Burgess]

From: Reuben Thomas <rrt@sc3d.org>

The gdb_select.h file was moved to the gdbsupport directory long ago,
but a reference was accident left in gdb/Makefile.in (in the
HFILES_NO_SRCDIR variable), this commit removes that reference.

Before this commit, if I use 'make tags' here's what I see:

  $ make tags
  make: *** No rule to make target 'gdb_select.h', needed by 'TAGS'.  Stop.

After this commit 'make tags' completes, but I still see these
warnings:

  ../../src/gdb/arm.c: No such file or directory
  ../../src/gdb/arm-get-next-pcs.c: No such file or directory
  ../../src/gdb/arm-linux.c: No such file or directory

These are caused by a separate issue, and will be addressed in the
next commit.
---
 gdb/Makefile.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 009b733092d..3df09e6a43b 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1321,7 +1321,6 @@ HFILES_NO_SRCDIR = \
 	gdb_curses.h \
 	gdb_expat.h \
 	gdb_proc_service.h \
-	gdb_select.h \
 	gdb-stabs.h \
 	gdb_vfork.h \
 	gdb_wchar.h \
-- 
2.25.4

[PATCHv2 3/3] gdb/Makefile.in: move ALLDEPFILES earlier in Makefile.in

[Andrew Burgess]

If I do 'make tags' in the gdb build directory, the tags target does
complete, but I see these warnings:

  ../../src/gdb/arm.c: No such file or directory
  ../../src/gdb/arm-get-next-pcs.c: No such file or directory
  ../../src/gdb/arm-linux.c: No such file or directory

The reason for this is the ordering of build rules and make variables
in gdb/Makefile.in, specifically, the placement of the tags related
rules, and the ALLDEPFILES variable.  The ordering is like this:

  TAGFILES_NO_SRCDIR = .... $(ALLDEPFILES) ....

  TAGS: $(TAGFILES_NO_SRCDIR) ....
          # Recipe uses $(TAGFILES_NO_SRCDIR)

  tags: TAGS

  ALLDEPFILES = .....

When the TAGS rule is parsed TAGFILES_NO_SRCDIR is expanded, which
then expands ALLDEPFILES, which, at that point in the Makefile is
undefined, and so expands to the empty string.  As a result TAGS does
not depend on any file listed in ALLDEPFILES.

However, when the TAGS recipe is invoked ALLDEPFILES is now defined.
As a result, all the files in ALLDEPFILES are passed to the etags
program.

The ALLDEPFILES references three files, arm.c, arm-get-next-pcs.c, and
arm-linux.c, which are actually in the gdb/arch/ directory, but, in
ALLDEPFILES these files don't include the arch/ prefix.  As a result,
the etags program ends up looking for these files in the wrong
location.

As ALLDEPFILES is only used by the TAGS rule, this mistake was not
previously noticed (the TAGS rule itself was broken until a recent
commit).

In this commit I make two changes, first, I move ALLDEPFILES to be
defined before TAGFILES_NO_SRCDIR, this means that the TAGS rule will
depend on all the files in ALLDEPFILES.  With this change the TAGS
rule now breaks complaining that there's no rule to build the 3 files
mentioned above.

Next, I have added all *.c files in gdb/arch/ to ALLDEPFILES,
including their arch/ prefix, and removed the incorrect (missing arch/
prefix) references.

With these two changes the TAGS (or tags if you prefer) target now
builds without any errors or warnings.
---
 gdb/Makefile.in | 447 +++++++++++++++++++++++++-----------------------
 1 file changed, 229 insertions(+), 218 deletions(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 3df09e6a43b..a775b2f4d19 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1589,6 +1589,235 @@ HFILES_WITH_SRCDIR = \
 
 DEPFILES = $(TARGET_OBS) $(SER_HARDWIRE) $(NATDEPFILES) $(SIM_OBS)
 
+ALLDEPFILES = \
+	arch/aarch32.c \
+	arch/aarch64.c \
+	arch/aarch64-insn.c \
+	arch/aarch64-mte-linux.c \
+	arch/amd64.c \
+	arch/arc.c \
+	arch/arm.c \
+	arch/arm-get-next-pcs.c \
+	arch/arm-linux.c \
+	arch/i386.c \
+	arch/loongarch.c \
+	arch/ppc-linux-common.c \
+	arch/riscv.c \
+	arch/tic6x.c \
+	aarch32-tdep.c \
+	aarch64-fbsd-nat.c \
+	aarch64-fbsd-tdep.c \
+	aarch64-linux-nat.c \
+	aarch64-linux-tdep.c \
+	aarch64-newlib-tdep.c \
+	aarch64-ravenscar-thread.c \
+	aarch64-tdep.c \
+	aix-thread.c \
+	alpha-bsd-nat.c \
+	alpha-bsd-tdep.c \
+	alpha-linux-nat.c \
+	alpha-linux-tdep.c \
+	alpha-mdebug-tdep.c \
+	alpha-netbsd-tdep.c \
+	alpha-obsd-tdep.c \
+	alpha-tdep.c \
+	amd64-bsd-nat.c \
+	amd64-darwin-tdep.c \
+	amd64-dicos-tdep.c \
+	amd64-fbsd-nat.c \
+	amd64-fbsd-tdep.c \
+	amd64-linux-nat.c \
+	amd64-linux-tdep.c \
+	amd64-nat.c \
+	amd64-netbsd-nat.c \
+	amd64-netbsd-tdep.c \
+	amd64-obsd-nat.c \
+	amd64-obsd-tdep.c \
+	amd64-ravenscar-thread.c \
+	amd64-sol2-tdep.c \
+	amd64-tdep.c \
+	arc-linux-nat.c \
+	arc-tdep.c \
+	arm-bsd-tdep.c \
+	arm-fbsd-nat.c \
+	arm-fbsd-tdep.c \
+	arm-linux-nat.c \
+	arm-linux-tdep.c \
+	arm-netbsd-nat.c \
+	arm-netbsd-tdep.c \
+	arm-none-tdep.c \
+	arm-obsd-tdep.c \
+	arm-tdep.c \
+	avr-tdep.c \
+	bfin-linux-tdep.c \
+	bfin-tdep.c \
+	bpf-tdep.c \
+	bsd-kvm.c \
+	bsd-uthread.c \
+	csky-linux-tdep.c \
+	csky-tdep.c \
+	darwin-nat.c \
+	dicos-tdep.c \
+	fbsd-nat.c \
+	fbsd-tdep.c \
+	fork-child.c \
+	ft32-tdep.c \
+	glibc-tdep.c \
+	go32-nat.c \
+	h8300-tdep.c \
+	hppa-bsd-tdep.c \
+	hppa-linux-nat.c \
+	hppa-linux-tdep.c \
+	hppa-netbsd-nat.c \
+	hppa-netbsd-tdep.c \
+	hppa-obsd-nat.c \
+	hppa-obsd-tdep.c \
+	hppa-tdep.c \
+	i386-bsd-nat.c \
+	i386-bsd-tdep.c \
+	i386-darwin-nat.c \
+	i386-darwin-tdep.c \
+	i386-dicos-tdep.c \
+	i386-fbsd-nat.c \
+	i386-fbsd-tdep.c \
+	i386-gnu-nat.c \
+	i386-gnu-tdep.c \
+	i386-linux-nat.c \
+	i386-linux-tdep.c \
+	i386-netbsd-nat.c \
+	i386-netbsd-tdep.c \
+	i386-obsd-nat.c \
+	i386-obsd-tdep.c \
+	i386-sol2-nat.c \
+	i386-sol2-tdep.c \
+	i386-tdep.c \
+	i386-windows-tdep.c \
+	i387-tdep.c \
+	ia64-libunwind-tdep.c \
+	ia64-linux-nat.c \
+	ia64-linux-tdep.c \
+	ia64-tdep.c \
+	ia64-vms-tdep.c \
+	inf-ptrace.c \
+	linux-fork.c \
+	linux-record.c \
+	linux-tdep.c \
+	lm32-tdep.c \
+	loongarch-linux-nat.c \
+	loongarch-linux-tdep.c \
+	loongarch-tdep.c \
+	m32r-linux-nat.c \
+	m32r-linux-tdep.c \
+	m32r-tdep.c \
+	m68hc11-tdep.c \
+	m68k-bsd-nat.c \
+	m68k-bsd-tdep.c \
+	m68k-linux-nat.c \
+	m68k-linux-tdep.c \
+	m68k-tdep.c \
+	microblaze-linux-tdep.c \
+	microblaze-tdep.c \
+	mingw-hdep.c \
+	mips-fbsd-nat.c \
+	mips-fbsd-tdep.c \
+	mips-linux-nat.c \
+	mips-linux-tdep.c \
+	mips-netbsd-nat.c \
+	mips-netbsd-tdep.c \
+	mips-sde-tdep.c \
+	mips-tdep.c \
+	mips64-obsd-nat.c \
+	mips64-obsd-tdep.c \
+	msp430-tdep.c \
+	netbsd-nat.c \
+	netbsd-tdep.c \
+	nds32-tdep.c \
+	nios2-linux-tdep.c \
+	nios2-tdep.c \
+	obsd-nat.c \
+	obsd-tdep.c \
+	or1k-linux-nat.c \
+	posix-hdep.c \
+	ppc-fbsd-nat.c \
+	ppc-fbsd-tdep.c \
+	ppc-linux-nat.c \
+	ppc-linux-tdep.c \
+	ppc-netbsd-nat.c \
+	ppc-netbsd-tdep.c \
+	ppc-obsd-nat.c \
+	ppc-obsd-tdep.c \
+	ppc-ravenscar-thread.c \
+	ppc-sysv-tdep.c \
+	ppc64-tdep.c \
+	procfs.c \
+	ravenscar-thread.c \
+	remote-sim.c \
+	riscv-fbsd-nat.c \
+	riscv-fbsd-tdep.c \
+	riscv-linux-nat.c \
+	riscv-linux-tdep.c \
+	riscv-none-tdep.c \
+	riscv-ravenscar-thread.c \
+	riscv-tdep.c \
+	rl78-tdep.c \
+	rs6000-aix-nat.c \
+	rs6000-lynx178-tdep.c \
+	rs6000-tdep.c \
+	rx-tdep.c \
+	s390-linux-nat.c \
+	s390-linux-tdep.c \
+	s390-tdep.c \
+	ser-go32.c \
+	ser-mingw.c \
+	ser-pipe.c \
+	ser-tcp.c \
+	ser-uds.c \
+	sh-netbsd-nat.c \
+	sh-netbsd-tdep.c \
+	sh-tdep.c \
+	sol2-tdep.c \
+	solib-aix.c \
+	solib-svr4.c \
+	sparc-linux-nat.c \
+	sparc-linux-tdep.c \
+	sparc-nat.c \
+	sparc-netbsd-nat.c \
+	sparc-netbsd-tdep.c \
+	sparc-obsd-tdep.c \
+	sparc-ravenscar-thread.c \
+	sparc-sol2-nat.c \
+	sparc-sol2-tdep.c \
+	sparc-tdep.c \
+	sparc64-fbsd-nat.c \
+	sparc64-fbsd-tdep.c \
+	sparc64-linux-nat.c \
+	sparc64-linux-tdep.c \
+	sparc64-nat.c \
+	sparc64-netbsd-nat.c \
+	sparc64-netbsd-tdep.c \
+	sparc64-obsd-nat.c \
+	sparc64-obsd-tdep.c \
+	sparc64-sol2-tdep.c \
+	sparc64-tdep.c \
+	tilegx-linux-nat.c \
+	tilegx-linux-tdep.c \
+	tilegx-tdep.c \
+	v850-tdep.c \
+	vax-bsd-nat.c \
+	vax-netbsd-tdep.c \
+	vax-tdep.c \
+	windows-nat.c \
+	windows-tdep.c \
+	x86-nat.c \
+	x86-tdep.c \
+	xcoffread.c \
+	xstormy16-tdep.c \
+	xtensa-config.c \
+	xtensa-linux-nat.c \
+	xtensa-linux-tdep.c \
+	xtensa-tdep.c \
+	xtensa-xtregs.c
+
 # Don't include YYFILES (*.c) because we already include *.y in SFILES,
 # and it's more useful to see it in the .y file.
 TAGFILES_NO_SRCDIR = $(SFILES) $(HFILES_NO_SRCDIR) $(ALLDEPFILES) \
@@ -2132,224 +2361,6 @@ force_update:
 # will remove them.
 MAKEOVERRIDES =
 
-ALLDEPFILES = \
-	aarch32-tdep.c \
-	aarch64-fbsd-nat.c \
-	aarch64-fbsd-tdep.c \
-	aarch64-linux-nat.c \
-	aarch64-linux-tdep.c \
-	aarch64-newlib-tdep.c \
-	aarch64-ravenscar-thread.c \
-	aarch64-tdep.c \
-	aix-thread.c \
-	alpha-bsd-nat.c \
-	alpha-bsd-tdep.c \
-	alpha-linux-nat.c \
-	alpha-linux-tdep.c \
-	alpha-mdebug-tdep.c \
-	alpha-netbsd-tdep.c \
-	alpha-obsd-tdep.c \
-	alpha-tdep.c \
-	amd64-bsd-nat.c \
-	amd64-darwin-tdep.c \
-	amd64-dicos-tdep.c \
-	amd64-fbsd-nat.c \
-	amd64-fbsd-tdep.c \
-	amd64-linux-nat.c \
-	amd64-linux-tdep.c \
-	amd64-nat.c \
-	amd64-netbsd-nat.c \
-	amd64-netbsd-tdep.c \
-	amd64-obsd-nat.c \
-	amd64-obsd-tdep.c \
-	amd64-ravenscar-thread.c \
-	amd64-sol2-tdep.c \
-	amd64-tdep.c \
-	arc-linux-nat.c \
-	arc-tdep.c \
-	arm.c \
-	arm-bsd-tdep.c \
-	arm-fbsd-nat.c \
-	arm-fbsd-tdep.c \
-	arm-get-next-pcs.c \
-	arm-linux.c \
-	arm-linux-nat.c \
-	arm-linux-tdep.c \
-	arm-netbsd-nat.c \
-	arm-netbsd-tdep.c \
-	arm-none-tdep.c \
-	arm-obsd-tdep.c \
-	arm-tdep.c \
-	avr-tdep.c \
-	bfin-linux-tdep.c \
-	bfin-tdep.c \
-	bpf-tdep.c \
-	bsd-kvm.c \
-	bsd-uthread.c \
-	csky-linux-tdep.c \
-	csky-tdep.c \
-	darwin-nat.c \
-	dicos-tdep.c \
-	fbsd-nat.c \
-	fbsd-tdep.c \
-	fork-child.c \
-	ft32-tdep.c \
-	glibc-tdep.c \
-	go32-nat.c \
-	h8300-tdep.c \
-	hppa-bsd-tdep.c \
-	hppa-linux-nat.c \
-	hppa-linux-tdep.c \
-	hppa-netbsd-nat.c \
-	hppa-netbsd-tdep.c \
-	hppa-obsd-nat.c \
-	hppa-obsd-tdep.c \
-	hppa-tdep.c \
-	i386-bsd-nat.c \
-	i386-bsd-tdep.c \
-	i386-darwin-nat.c \
-	i386-darwin-tdep.c \
-	i386-dicos-tdep.c \
-	i386-fbsd-nat.c \
-	i386-fbsd-tdep.c \
-	i386-gnu-nat.c \
-	i386-gnu-tdep.c \
-	i386-linux-nat.c \
-	i386-linux-tdep.c \
-	i386-netbsd-nat.c \
-	i386-netbsd-tdep.c \
-	i386-obsd-nat.c \
-	i386-obsd-tdep.c \
-	i386-sol2-nat.c \
-	i386-sol2-tdep.c \
-	i386-tdep.c \
-	i386-windows-tdep.c \
-	i387-tdep.c \
-	ia64-libunwind-tdep.c \
-	ia64-linux-nat.c \
-	ia64-linux-tdep.c \
-	ia64-tdep.c \
-	ia64-vms-tdep.c \
-	inf-ptrace.c \
-	linux-fork.c \
-	linux-record.c \
-	linux-tdep.c \
-	lm32-tdep.c \
-	loongarch-linux-nat.c \
-	loongarch-linux-tdep.c \
-	loongarch-tdep.c \
-	m32r-linux-nat.c \
-	m32r-linux-tdep.c \
-	m32r-tdep.c \
-	m68hc11-tdep.c \
-	m68k-bsd-nat.c \
-	m68k-bsd-tdep.c \
-	m68k-linux-nat.c \
-	m68k-linux-tdep.c \
-	m68k-tdep.c \
-	microblaze-linux-tdep.c \
-	microblaze-tdep.c \
-	mingw-hdep.c \
-	mips-fbsd-nat.c \
-	mips-fbsd-tdep.c \
-	mips-linux-nat.c \
-	mips-linux-tdep.c \
-	mips-netbsd-nat.c \
-	mips-netbsd-tdep.c \
-	mips-sde-tdep.c \
-	mips-tdep.c \
-	mips64-obsd-nat.c \
-	mips64-obsd-tdep.c \
-	msp430-tdep.c \
-	netbsd-nat.c \
-	netbsd-tdep.c \
-	nds32-tdep.c \
-	nios2-linux-tdep.c \
-	nios2-tdep.c \
-	obsd-nat.c \
-	obsd-tdep.c \
-	or1k-linux-nat.c \
-	posix-hdep.c \
-	ppc-fbsd-nat.c \
-	ppc-fbsd-tdep.c \
-	ppc-linux-nat.c \
-	ppc-linux-tdep.c \
-	ppc-netbsd-nat.c \
-	ppc-netbsd-tdep.c \
-	ppc-obsd-nat.c \
-	ppc-obsd-tdep.c \
-	ppc-ravenscar-thread.c \
-	ppc-sysv-tdep.c \
-	ppc64-tdep.c \
-	procfs.c \
-	ravenscar-thread.c \
-	remote-sim.c \
-	riscv-fbsd-nat.c \
-	riscv-fbsd-tdep.c \
-	riscv-linux-nat.c \
-	riscv-linux-tdep.c \
-	riscv-none-tdep.c \
-	riscv-ravenscar-thread.c \
-	riscv-tdep.c \
-	rl78-tdep.c \
-	rs6000-aix-nat.c \
-	rs6000-lynx178-tdep.c \
-	rs6000-tdep.c \
-	rx-tdep.c \
-	s390-linux-nat.c \
-	s390-linux-tdep.c \
-	s390-tdep.c \
-	ser-go32.c \
-	ser-mingw.c \
-	ser-pipe.c \
-	ser-tcp.c \
-	ser-uds.c \
-	sh-netbsd-nat.c \
-	sh-netbsd-tdep.c \
-	sh-tdep.c \
-	sol2-tdep.c \
-	solib-aix.c \
-	solib-svr4.c \
-	sparc-linux-nat.c \
-	sparc-linux-tdep.c \
-	sparc-nat.c \
-	sparc-netbsd-nat.c \
-	sparc-netbsd-tdep.c \
-	sparc-obsd-tdep.c \
-	sparc-ravenscar-thread.c \
-	sparc-sol2-nat.c \
-	sparc-sol2-tdep.c \
-	sparc-tdep.c \
-	sparc64-fbsd-nat.c \
-	sparc64-fbsd-tdep.c \
-	sparc64-linux-nat.c \
-	sparc64-linux-tdep.c \
-	sparc64-nat.c \
-	sparc64-netbsd-nat.c \
-	sparc64-netbsd-tdep.c \
-	sparc64-obsd-nat.c \
-	sparc64-obsd-tdep.c \
-	sparc64-sol2-tdep.c \
-	sparc64-tdep.c \
-	tilegx-linux-nat.c \
-	tilegx-linux-tdep.c \
-	tilegx-tdep.c \
-	v850-tdep.c \
-	vax-bsd-nat.c \
-	vax-netbsd-tdep.c \
-	vax-tdep.c \
-	windows-nat.c \
-	windows-tdep.c \
-	x86-nat.c \
-	x86-tdep.c \
-	xcoffread.c \
-	xstormy16-tdep.c \
-	xtensa-config.c \
-	xtensa-linux-nat.c \
-	xtensa-linux-tdep.c \
-	xtensa-tdep.c \
-	xtensa-xtregs.c
-
 # Some files need explicit build rules (due to -Werror problems) or due
 # to sub-directory fun 'n' games.
 
-- 
2.25.4

Re: [PATCHv2 0/3] Fix for 'make tags' build rule

[Andrew Burgess]

Andrew Burgess <aburgess@redhat.com> writes:

> Hi Reuben,
>
> Thanks for working on this, sorry your original patch didn't get
> merged.
>
> I took a look at your updated patch, and noticed what I think is a
> merge issue with your update, you've removed gdb_select.h, but added
> back in gdb_regex.h, I don't think this is intentional.
>
> Anyway, I was going to fix that and push your patch, but first I
> thought I'd test 'make tags' - and I noticed some additional problems.
>
> The series below fixes these issues.
>
>  #1 - this is a general clean up, and is not really related to 'make
>       tags' at all,
>
>  #2 - this is your patch, but with the merge issue mentioned above
>       fixed.
>
>  #3 - this fixes some additional warnings I was seeing from 'make
>       tags'.
>
> I'll give this some time for folk to comment before pushing.

I've gone ahead and pushed this series.  I think all the fixes are
reasonably obvious.

Thanks,
Andrew



>
> Thanks for your work on this,
>
> Andrew
>
> ---
>
> Andrew Burgess (2):
>   gdb/Makefile.in: remove SOURCES variable
>   gdb/Makefile.in: move ALLDEPFILES earlier in Makefile.in
>
> Reuben Thomas (1):
>   gdb/Makefile.in: fix 'make tags' build target
>
>  gdb/Makefile.in | 449 ++++++++++++++++++++++++------------------------
>  1 file changed, 229 insertions(+), 220 deletions(-)
>
> -- 
> 2.25.4