[Bug build/30108] New: gdb info docs fail to build when configured --with-system-readlne

[Bug build/30108] New: gdb info docs fail to build when configured --with-system-readlne

[doko at debian dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30108

            Bug ID: 30108
           Summary: gdb info docs fail to build when configured
                    --with-system-readlne
           Product: gdb
           Version: 13.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: doko at debian dot org
  Target Milestone: ---

this seems to be different than #27808. with --with-system-readline configured,
the build fails because it cannot find the readline includes.  These are always
taken from the source tree, this should not be dependent on this configuration
option.

seen on both the 13 branch and trunk. proposed patch:

--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -590,7 +590,7 @@ if test "$with_system_readline" = yes; t
   READLINE=-lreadline
   READLINE_DEPS=
   READLINE_CFLAGS=
-  READLINE_TEXI_INCFLAG=
+  READLINE_TEXI_INCFLAG='-I $(READLINE_DIR)'
 else
   READLINE='$(READLINE_DIR)/libreadline.a'
   READLINE_DEPS='$(READLINE)'

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30108] gdb info docs fail to build when configured --with-system-readlne

[doko at debian dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30108

Matthias Klose <doko at debian dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brobecke at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30108] gdb info docs fail to build when configured --with-system-readlne

[keiths at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30108

Keith Seitz <keiths at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |keiths at redhat dot com
           Assignee|unassigned at sourceware dot org   |keiths at redhat dot com

--- Comment #1 from Keith Seitz <keiths at redhat dot com> ---
(In reply to Matthias Klose from comment #0)
> this seems to be different than #27808. with --with-system-readline
> configured, the build fails because it cannot find the readline includes. 
> These are always taken from the source tree, this should not be dependent on
> this configuration option.
> 
> seen on both the 13 branch and trunk. proposed patch:

Thanks for the report! I've confirmed this locally on origin/master.

> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -590,7 +590,7 @@ if test "$with_system_readline" = yes; t
>    READLINE=-lreadline
>    READLINE_DEPS=
>    READLINE_CFLAGS=
> -  READLINE_TEXI_INCFLAG=
> +  READLINE_TEXI_INCFLAG='-I $(READLINE_DIR)'
>  else
>    READLINE='$(READLINE_DIR)/libreadline.a'
>    READLINE_DEPS='$(READLINE)'

I don't think this is really what we want to do. As mentioned in build/27808,
gdb.texinfo contains markers which should prevent these from being needed. The
real issue is that doc/Makefile.in:GDB_DOC_SOURCE_INCLUDES unconditionally
includes
the readline texi files, and it should not.

I have an alternate patch which I am testing and will propose to the mailing
list (where all patches are discussed and reviewed).

Thank you for bringing this to our attention!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30108] gdb info docs fail to build when configured --with-system-readlne

[keiths at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30108

--- Comment #2 from Keith Seitz <keiths at redhat dot com> ---
Proposed patch:
https://sourceware.org/pipermail/gdb-patches/2023-February/196862.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30108] gdb info docs fail to build when configured --with-system-readlne

[brobecker at gnat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30108

Joel Brobecker <brobecker at gnat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.1
                 CC|                            |brobecker at gnat dot com

--- Comment #3 from Joel Brobecker <brobecker at gnat dot com> ---
I added the target-milestone as 13.1 to see if we can include this fix in time
for gdb 13.1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30108] gdb info docs fail to build when configured --with-system-readlne

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30108

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Keith Seitz <kseitz@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=14d0e6818a022b72c265f15f63c8ccc2fc8c302a

commit 14d0e6818a022b72c265f15f63c8ccc2fc8c302a
Author: Keith Seitz <keiths@redhat.com>
Date:   Mon Feb 13 06:14:40 2023 -0800

    Fix doc build dependencies for --with-system-readline

    PR build/30108 concerns building gdb documentation with
    --with-sytem-readline.  If the in-tree readline directory is
    missing, though, the docs will fail to build:

    make[4]: Entering directory
'/home/keiths/work/readline-doc-issue/linux/gdb/doc'
    make[4]: *** No rule to make target
'../../../src/gdb/doc/../../readline/readline/doc/rluser.texi', needed by
'gdb.info'.  Stop.

    The listed file (and hsuser.texi) are conditionally included by
gdb.texinfo.
    When system readline is used, gdb/configure.ac will leave
    READLINE_TEXI_INCFLAGS empty, causing doc/Makefile.in to output a line to
    $BUILD/doc/GDBvn.texi with "@set SYSTEM_READLINE".  This surpresses the
    inclusion of the missing files. They are not needed or used in this
    scenario.

    However, GDB_DOC_SOURCE_INCLUDES always lists these two files as
dependencies,
    thus provoking the build error whenever readline/ is missing.

    This patch fixes this by creating (essentially) a conditional setting of
the
    dependencies to be included from readline.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30108] gdb info docs fail to build when configured --with-system-readlne

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30108

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-13-branch branch has been updated by Keith Seitz
<kseitz@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c594b6f7d5dd50bc0ae3b0f15b556bfe592893bb

commit c594b6f7d5dd50bc0ae3b0f15b556bfe592893bb
Author: Keith Seitz <keiths@redhat.com>
Date:   Mon Feb 13 06:14:40 2023 -0800

    Fix doc build dependencies for --with-system-readline

    PR build/30108 concerns building gdb documentation with
    --with-sytem-readline.  If the in-tree readline directory is
    missing, though, the docs will fail to build:

    make[4]: Entering directory
'/home/keiths/work/readline-doc-issue/linux/gdb/doc'
    make[4]: *** No rule to make target
'../../../src/gdb/doc/../../readline/readline/doc/rluser.texi', needed by
'gdb.info'.  Stop.

    The listed file (and hsuser.texi) are conditionally included by
gdb.texinfo.
    When system readline is used, gdb/configure.ac will leave
    READLINE_TEXI_INCFLAGS empty, causing doc/Makefile.in to output a line to
    $BUILD/doc/GDBvn.texi with "@set SYSTEM_READLINE".  This surpresses the
    inclusion of the missing files. They are not needed or used in this
    scenario.

    However, GDB_DOC_SOURCE_INCLUDES always lists these two files as
dependencies,
    thus provoking the build error whenever readline/ is missing.

    This patch fixes this by creating (essentially) a conditional setting of
the
    dependencies to be included from readline.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30108] gdb info docs fail to build when configured --with-system-readlne

[keiths at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30108

Keith Seitz <keiths at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Keith Seitz <keiths at redhat dot com> ---
Patch approved and pushed to origin/master and gdb-13-branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.