[Bug tui/31522] TUI misses highlight after run to main

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31522

--- Comment #15 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b35013e29f3bcf9028aa22291f378010420322fe

commit b35013e29f3bcf9028aa22291f378010420322fe
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Apr 2 16:09:10 2024 +0200

    [gdb/tui] Fix centering and highlighting of current line

    After starting TUI like this with a hello world a.out:
    ...
    $ gdb -q a.out -ex start -ex "tui enable"
    ...
    we get:
    ...
   
ââhello.câââââââââââââââââââââââââââââââ
    â        5 {                           â
    â        6   printf ("hello\n");       â
    â        7                             â
    â        8   return 0;                 â
    â        9 }                           â
    â                                      â
   
ââââââââââââââââââââââââââââââââââââââââ
    ...

    This is a regression since commit ee1e9bbb513 ("[gdb/tui] Fix displaying
main
    after resizing"), before which we had instead:
    ...
   
ââhello.câââââââââââââââââââââââââââââââ
    â        4 main (void)                 â
    â        5 {                           â
    â  >     6 [7m  printf ("hello\n");[0m       â
    â        7                             â
    â        8   return 0;                 â
    â        9 }                           â
   
ââââââââââââââââââââââââââââââââââââââââ
    ...

    In other words, the problems are:
    - the active line (source line 6) is no longer highlighted, and
    - the active line is not vertically centered (screen line 2 out 6 instead
of
      screen line 3 out of 6).

    Fix these problems respectively by:
    - in tui_enable, instead of "tui_show_frame_info (0)" using
      'tui_show_frame_info (deprecated_safe_get_selected_frame ())", and
    - in tui_source_window_base::rerender, adding centering functionality.

    Tested on aarch64-linux.

    Co-Authored-By: Tom Tromey <tom@tromey.com>
    Approved-By: Tom Tromey <tom@tromey.com>

    PR tui/31522
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31522

-- 
You are receiving this mail because:
You are on the CC list for the bug.