[Bug tui/31522] TUI misses highlight after run to main

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31522

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

--- Comment #12 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Pedro Alves from comment #8)
> Thanks!  Indeed, I played a bit with that patch, and the centering seems to
> work just like it did before, in all the use cases I threw at it.  Tromey's
> change is also needed for the highlight.
> 

Thanks for trying it out (maybe consider adding a tested-by tag to the
submitted patch?).

> The old code did:
> 
> -  if (deprecated_safe_get_selected_frame ())
> -    tui_show_frame_info (deprecated_safe_get_selected_frame ());
> -  else
> -    tui_display_main ();
> 
> and I wondered whether we need that tui_display_main call, but I couldn't
> spot a behavior difference without it.  I tried enabling the TUI before
> starting the program, with and without using "list foo" to move the current
> source position elsewhere.
> 

Ok, understood.

> IMO, it would be nice if we centered in more cases, like after "frame", for
> example, or before running the program and you enable the TUI (TUI shows
> main), but those are not regressions AFAICT.

Agreed.  I played a bit with 'gdb -q a.out -tui' vs 'gdb -q -a.out -ex "tui
enable"', where there's also a difference in behaviour.

Anyway, since this is a regression fix, I went with this minimal fix, and added
a comment at the fix that we could try to improve the fix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.