public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "pedro at palves dot net" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug tui/31522] TUI misses highlight after run to main Date: Thu, 28 Mar 2024 11:07:43 +0000 [thread overview] Message-ID: <bug-31522-4717-6cI8U0uHaM@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-31522-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=31522 --- Comment #8 from Pedro Alves <pedro at palves dot net> --- Thanks! Indeed, I played a bit with that patch, and the centering seems to work just like it did before, in all the use cases I threw at it. Tromey's change is also needed for the highlight. The old code did: - if (deprecated_safe_get_selected_frame ()) - tui_show_frame_info (deprecated_safe_get_selected_frame ()); - else - tui_display_main (); and I wondered whether we need that tui_display_main call, but I couldn't spot a behavior difference without it. I tried enabling the TUI before starting the program, with and without using "list foo" to move the current source position elsewhere. IMO, it would be nice if we centered in more cases, like after "frame", for example, or before running the program and you enable the TUI (TUI shows main), but those are not regressions AFAICT. -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2024-03-28 11:07 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-21 15:57 [Bug tui/31522] New: " pedro at palves dot net 2024-03-21 16:19 ` [Bug tui/31522] " ssbssa at sourceware dot org 2024-03-21 16:19 ` tromey at sourceware dot org 2024-03-22 16:24 ` tromey at sourceware dot org 2024-03-25 23:18 ` tromey at sourceware dot org 2024-03-25 23:18 ` tromey at sourceware dot org 2024-03-26 0:26 ` tromey at sourceware dot org 2024-03-26 13:15 ` pedro at palves dot net 2024-03-27 1:10 ` tromey at sourceware dot org 2024-03-27 8:33 ` vries at gcc dot gnu.org 2024-03-27 22:35 ` tromey at sourceware dot org 2024-03-28 10:33 ` vries at gcc dot gnu.org 2024-03-28 11:07 ` pedro at palves dot net [this message] 2024-03-28 12:00 ` vries at gcc dot gnu.org 2024-03-28 14:34 ` vries at gcc dot gnu.org 2024-03-28 14:35 ` vries at gcc dot gnu.org 2024-03-28 14:50 ` vries at gcc dot gnu.org 2024-03-28 16:43 ` pedro at palves dot net 2024-03-28 22:26 ` tromey at sourceware dot org 2024-04-02 14:09 ` cvs-commit at gcc dot gnu.org 2024-04-02 14:10 ` vries at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-31522-4717-6cI8U0uHaM@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).