[Bug tui/31522] TUI misses highlight after run to main

["pedro at palves dot net" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31522

--- Comment #3 from Pedro Alves <pedro at palves dot net> ---
> Not sure what broke this, but changing tui_enable to pass
> the selected frame to tui_show_frame_info fixes it.

Thanks, I gave that a try, but it still doesn't behave like before.  It shows
the current line at the top of the source window, instead of in the middle. 
That's a bit of an usability regression, as it doesn't even show the line with
the function name.

> This seems reasonable to me, but maybe it is a change if
> you exit the TUI and then re-enter it in some scenario.
> Personally I'm not too concerned about this.

I do that frequently with c-x,a.  I'll be debugging gdb, and stepping/nexting
with the TUI enabled, then decide I'm at the right spot the program that I want
to inspect variables or run a command that I know is going to output many
lines, so I'll switch out of the TUI, issue whatever commands, and then
re-enable the TUI to continue stepping, etc.  I don't know if passing the frame
causes the TUI to lose its selected context/line when it was active or not. 
Seems like not from a quick experimentation.

BTW, this is what I tried following your instructions:

 --- c/gdb/tui/tui.c
 +++ w/gdb/tui/tui.c
 @@ -467,7 +467,7 @@ tui_enable (void)
       tui_set_term_width_to (COLS);
       def_prog_mode ();

 -      tui_show_frame_info (0);
 +      tui_show_frame_info (get_selected_frame (nullptr));

(Of course, this misbehaves if you enable the TUI before starting a process.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.