public inbox for glibc-bugs-regex@sourceware.org
help / color / mirror / Atom feed
* [Bug regex/860] New: bad guard in find_recover_state do-while loop
@ 2005-04-19  1:03 svdb+sources dot redhat dot com-bugs at stack dot nl
  2005-04-19  6:57 ` [Bug regex/860] " paolo dot bonzini at lu dot unisi dot ch
  2005-09-27  5:50 ` drepper at redhat dot com
  0 siblings, 2 replies; 3+ messages in thread
From: svdb+sources dot redhat dot com-bugs at stack dot nl @ 2005-04-19  1:03 UTC (permalink / raw)
  To: glibc-bugs-regex

While compiling the regex code with extra warnings on, from outside libc, quite 
a lot of warnings were reported. While these warnings were very justified, most 
of the underlying problems would not cause the actual code to behave in a non-
intended way. But one is very much a bug:
In find_recover_state, err is compared to REG_NOERROR, while it is *err which 
should be compared instead. Because of this the do-while loop will always 
terminate after one iteration.

I was working on getting rid of all the warnings in the regex code, which was 
taking quite a bit of time, as I needed to make sure I'm fixing the actual 
problems, and not (just) the symptoms. But then I noticed that the GNU coding 
guidelines stopped just short of saying "Listening to warnings to find a few 
bugs is not worth the effort.", which would explain the mess I'm encountering. I 
am willing to continue my work and submit a big patch with fixes that will clean 
up this code somewhat, but before I continue, I'd like to know whether such a 
patch will actually stand a chance of getting accepted.

-- 
           Summary: bad guard in find_recover_state do-while loop
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: regex
        AssignedTo: gotom at debian dot or dot jp
        ReportedBy: svdb+sources dot redhat dot com-bugs at stack dot nl
                CC: glibc-bugs-regex at sources dot redhat dot com,glibc-
                    bugs at sources dot redhat dot com


http://sources.redhat.com/bugzilla/show_bug.cgi?id=860

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-09-27  5:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-19  1:03 [Bug regex/860] New: bad guard in find_recover_state do-while loop svdb+sources dot redhat dot com-bugs at stack dot nl
2005-04-19  6:57 ` [Bug regex/860] " paolo dot bonzini at lu dot unisi dot ch
2005-09-27  5:50 ` drepper at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).