[Bug regex/860] New: bad guard in find_recover_state do-while loop

[Bug regex/860] New: bad guard in find_recover_state do-while loop

[svdb+sources dot redhat dot com-bugs at stack dot nl]

While compiling the regex code with extra warnings on, from outside libc, quite 
a lot of warnings were reported. While these warnings were very justified, most 
of the underlying problems would not cause the actual code to behave in a non-
intended way. But one is very much a bug:
In find_recover_state, err is compared to REG_NOERROR, while it is *err which 
should be compared instead. Because of this the do-while loop will always 
terminate after one iteration.

I was working on getting rid of all the warnings in the regex code, which was 
taking quite a bit of time, as I needed to make sure I'm fixing the actual 
problems, and not (just) the symptoms. But then I noticed that the GNU coding 
guidelines stopped just short of saying "Listening to warnings to find a few 
bugs is not worth the effort.", which would explain the mess I'm encountering. I 
am willing to continue my work and submit a big patch with fixes that will clean 
up this code somewhat, but before I continue, I'd like to know whether such a 
patch will actually stand a chance of getting accepted.

-- 
           Summary: bad guard in find_recover_state do-while loop
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: regex
        AssignedTo: gotom at debian dot or dot jp
        ReportedBy: svdb+sources dot redhat dot com-bugs at stack dot nl
                CC: glibc-bugs-regex at sources dot redhat dot com,glibc-
                    bugs at sources dot redhat dot com


http://sources.redhat.com/bugzilla/show_bug.cgi?id=860

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/860] bad guard in find_recover_state do-while loop

[paolo dot bonzini at lu dot unisi dot ch]

------- Additional Comments From paolo dot bonzini at lu dot unisi dot ch  2005-04-19 06:57 -------
Subject: Re:  New: bad guard in find_recover_state do-while
 loop


>I'd like to know whether such a 
>patch will actually stand a chance of getting accepted.
>
FWIW, I'm willing to "sponsor" such a patch.

You can attach it here and I'll review it even though I cannot approve it.

Paolo



-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=860

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/860] bad guard in find_recover_state do-while loop

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2005-09-27 05:50 -------
The referenced bug has since been fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=860

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.