* Re: [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32 [not found] <20120716201408.GA5091@intel.com> @ 2012-07-18 16:27 ` H.J. Lu 2012-07-18 18:44 ` Uros Bizjak 0 siblings, 1 reply; 4+ messages in thread From: H.J. Lu @ 2012-07-18 16:27 UTC (permalink / raw) To: Uros Bizjak, java-patches; +Cc: libffi-discuss, gcc-patches On Mon, Jul 16, 2012 at 01:14:08PM -0700, H.J. Lu wrote: > Hi, > > This patch defines FFI_SIZEOF_JAVA_RAW to 4 for x32, similar to MIPS n32. > It fixed: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53982 > > Hi, Here is the patch with updated ChangeLog entry. X32 has the same issue as MIPS n32, which was fixed by FFI_SIZEOF_JAVA_RAW: http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01612.html http://gcc.gnu.org/ml/gcc-patches/2007-12/msg00005.html The same fix is needed for x32. OK for trunk? Thanks. H.J. --- 2012-07-16 H.J. Lu <hongjiu.lu@intel.com> * src/x86/ffitarget.h: Check __ILP32__ instead of __LP64__ for x32. (FFI_SIZEOF_JAVA_RAW): Defined to 4 for x32. diff --git a/src/x86/ffitarget.h b/src/x86/ffitarget.h index f442654..46f294c 100644 --- a/src/x86/ffitarget.h +++ b/src/x86/ffitarget.h @@ -61,8 +61,9 @@ typedef unsigned long long ffi_arg; typedef long long ffi_sarg; #endif #else -#if defined __x86_64__ && !defined __LP64__ +#if defined __x86_64__ && defined __ILP32__ #define FFI_SIZEOF_ARG 8 +#define FFI_SIZEOF_JAVA_RAW 4 typedef unsigned long long ffi_arg; typedef long long ffi_sarg; #else -- 1.7.10.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32 2012-07-18 16:27 ` [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32 H.J. Lu @ 2012-07-18 18:44 ` Uros Bizjak 2012-07-18 19:11 ` H.J. Lu 0 siblings, 1 reply; 4+ messages in thread From: Uros Bizjak @ 2012-07-18 18:44 UTC (permalink / raw) To: H.J. Lu; +Cc: java-patches, libffi-discuss, gcc-patches On Wed, Jul 18, 2012 at 6:27 PM, H.J. Lu <hongjiu.lu@intel.com> wrote: >> This patch defines FFI_SIZEOF_JAVA_RAW to 4 for x32, similar to MIPS n32. >> It fixed: >> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53982 > > Here is the patch with updated ChangeLog entry. X32 has the same issue > as MIPS n32, which was fixed by FFI_SIZEOF_JAVA_RAW: > > http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01612.html > http://gcc.gnu.org/ml/gcc-patches/2007-12/msg00005.html > > The same fix is needed for x32. OK for trunk? > > 2012-07-16 H.J. Lu <hongjiu.lu@intel.com> > > * src/x86/ffitarget.h: Check __ILP32__ instead of __LP64__ for > x32. > (FFI_SIZEOF_JAVA_RAW): Defined to 4 for x32. How did you tested this patch? Does it fix all the problems from PR53982, including the one that is not 100% reproducible? Uros. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32 2012-07-18 18:44 ` Uros Bizjak @ 2012-07-18 19:11 ` H.J. Lu 2012-07-18 19:13 ` Uros Bizjak 0 siblings, 1 reply; 4+ messages in thread From: H.J. Lu @ 2012-07-18 19:11 UTC (permalink / raw) To: Uros Bizjak; +Cc: java-patches, libffi-discuss, gcc-patches On Wed, Jul 18, 2012 at 11:44 AM, Uros Bizjak <ubizjak@gmail.com> wrote: > On Wed, Jul 18, 2012 at 6:27 PM, H.J. Lu <hongjiu.lu@intel.com> wrote: > >>> This patch defines FFI_SIZEOF_JAVA_RAW to 4 for x32, similar to MIPS n32. >>> It fixed: >>> >>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53982 >> >> Here is the patch with updated ChangeLog entry. X32 has the same issue >> as MIPS n32, which was fixed by FFI_SIZEOF_JAVA_RAW: >> >> http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01612.html >> http://gcc.gnu.org/ml/gcc-patches/2007-12/msg00005.html >> >> The same fix is needed for x32. OK for trunk? >> >> 2012-07-16 H.J. Lu <hongjiu.lu@intel.com> >> >> * src/x86/ffitarget.h: Check __ILP32__ instead of __LP64__ for >> x32. >> (FFI_SIZEOF_JAVA_RAW): Defined to 4 for x32. > > How did you tested this patch? Does it fix all the problems from > PR53982, including the one that is not 100% reproducible? > I tested it on Linux/x32. All libjava tests are passing now for x32 with this patch. -- H.J. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32 2012-07-18 19:11 ` H.J. Lu @ 2012-07-18 19:13 ` Uros Bizjak 0 siblings, 0 replies; 4+ messages in thread From: Uros Bizjak @ 2012-07-18 19:13 UTC (permalink / raw) To: H.J. Lu; +Cc: java-patches, libffi-discuss, gcc-patches On Wed, Jul 18, 2012 at 9:10 PM, H.J. Lu <hjl.tools@gmail.com> wrote: >>>> This patch defines FFI_SIZEOF_JAVA_RAW to 4 for x32, similar to MIPS n32. >>>> It fixed: >>>> >>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53982 >>> >>> Here is the patch with updated ChangeLog entry. X32 has the same issue >>> as MIPS n32, which was fixed by FFI_SIZEOF_JAVA_RAW: >>> >>> http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01612.html >>> http://gcc.gnu.org/ml/gcc-patches/2007-12/msg00005.html >>> >>> The same fix is needed for x32. OK for trunk? >>> >>> 2012-07-16 H.J. Lu <hongjiu.lu@intel.com> >>> >>> * src/x86/ffitarget.h: Check __ILP32__ instead of __LP64__ for >>> x32. >>> (FFI_SIZEOF_JAVA_RAW): Defined to 4 for x32. >> >> How did you tested this patch? Does it fix all the problems from >> PR53982, including the one that is not 100% reproducible? >> > > I tested it on Linux/x32. All libjava tests are passing now for x32 with > this patch. OK then. Thanks, Uros. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-18 19:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20120716201408.GA5091@intel.com>
2012-07-18 16:27 ` [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32 H.J. Lu
2012-07-18 18:44 ` Uros Bizjak
2012-07-18 19:11 ` H.J. Lu
2012-07-18 19:13 ` Uros Bizjak
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).