* Fix libjava bootstrap failure around IUCLC
@ 2012-03-25 16:09 Gerald Pfeifer
2012-03-26 9:01 ` Andrew Haley
0 siblings, 1 reply; 11+ messages in thread
From: Gerald Pfeifer @ 2012-03-25 16:09 UTC (permalink / raw)
To: gcc-patches, java-patches
This has been introduced by
2012-03-16 Andrew John Hughes <ahughes@redhat.com>
* Makefile.am: Add natVMConsole.cc.
:
* java/io/VMConsole.h: Initial generation.
* java/io/VMConsole.java: Copied from classpath/vm/reference.
* java/io/natVMConsole.cc: Implemented readPassword.
where now bootstrap on FreeBSD, Darwin and possibly others is broken.
Tested on amd64-unknown-freebsd8.3. Okay?
Gerald
2012-03-25 Gerald Pfeifer <gerald@pfeifer.com>
PR libgcj/52694
* java/io/natVMConsole.cc (IUCLC): Define, if undefined.
Index: java/io/natVMConsole.cc
===================================================================
--- java/io/natVMConsole.cc (revision 185766)
+++ java/io/natVMConsole.cc (working copy)
@@ -19,6 +19,10 @@
#include <java/io/Console.h>
#include <java/io/VMConsole.h>
+#ifndef IUCLC
+#define IUCLC 0
+#endif
+
#define TERMIOS_ECHO_IFLAGS (IUCLC|IXON|IXOFF|IXANY)
#define TERMIOS_ECHO_LFLAGS (ECHO|ECHOE|ECHOK|ECHONL|TOSTOP)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Fix libjava bootstrap failure around IUCLC
2012-03-25 16:09 Fix libjava bootstrap failure around IUCLC Gerald Pfeifer
@ 2012-03-26 9:01 ` Andrew Haley
2012-03-26 10:11 ` Mark Wielaard
0 siblings, 1 reply; 11+ messages in thread
From: Andrew Haley @ 2012-03-26 9:01 UTC (permalink / raw)
To: java-patches
On 03/25/2012 05:08 PM, Gerald Pfeifer wrote:
> 2012-03-25 Gerald Pfeifer <gerald@pfeifer.com>
>
> PR libgcj/52694
> * java/io/natVMConsole.cc (IUCLC): Define, if undefined.
Sure. WTF is IUCLC anyway? :-)
Andrew.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Fix libjava bootstrap failure around IUCLC
2012-03-26 9:01 ` Andrew Haley
@ 2012-03-26 10:11 ` Mark Wielaard
2012-03-26 10:47 ` [cp-patches] " Pekka Enberg
2012-03-26 10:49 ` Andrew Haley
0 siblings, 2 replies; 11+ messages in thread
From: Mark Wielaard @ 2012-03-26 10:11 UTC (permalink / raw)
To: Andrew Haley; +Cc: java-patches, classpath-patches
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
On Mon, 2012-03-26 at 10:01 +0100, Andrew Haley wrote:
> On 03/25/2012 05:08 PM, Gerald Pfeifer wrote:
> > 2012-03-25 Gerald Pfeifer <gerald@pfeifer.com>
> >
> > PR libgcj/52694
> > * java/io/natVMConsole.cc (IUCLC): Define, if undefined.
>
> Sure. WTF is IUCLC anyway? :-)
(map) Input (characters) UpperCase (to) Lower Case.
It is a non-posix termios extension.
patch should also go into upstream classpath.
[-- Attachment #2: Attached message - Fix libjava bootstrap failure around IUCLC --]
[-- Type: message/rfc822, Size: 4504 bytes --]
From: Gerald Pfeifer <gerald@pfeifer.com>
To: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org
Subject: Fix libjava bootstrap failure around IUCLC
Date: Sun, 25 Mar 2012 18:08:56 +0200 (CEST)
Message-ID: <alpine.LNX.2.00.1203251807180.4039@gerinyyl.fvgr>
This has been introduced by
2012-03-16 Andrew John Hughes <ahughes@redhat.com>
* Makefile.am: Add natVMConsole.cc.
:
* java/io/VMConsole.h: Initial generation.
* java/io/VMConsole.java: Copied from classpath/vm/reference.
* java/io/natVMConsole.cc: Implemented readPassword.
where now bootstrap on FreeBSD, Darwin and possibly others is broken.
Tested on amd64-unknown-freebsd8.3. Okay?
Gerald
2012-03-25 Gerald Pfeifer <gerald@pfeifer.com>
PR libgcj/52694
* java/io/natVMConsole.cc (IUCLC): Define, if undefined.
Index: java/io/natVMConsole.cc
===================================================================
--- java/io/natVMConsole.cc (revision 185766)
+++ java/io/natVMConsole.cc (working copy)
@@ -19,6 +19,10 @@
#include <java/io/Console.h>
#include <java/io/VMConsole.h>
+#ifndef IUCLC
+#define IUCLC 0
+#endif
+
#define TERMIOS_ECHO_IFLAGS (IUCLC|IXON|IXOFF|IXANY)
#define TERMIOS_ECHO_LFLAGS (ECHO|ECHOE|ECHOK|ECHONL|TOSTOP)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [cp-patches] Fix libjava bootstrap failure around IUCLC
2012-03-26 10:11 ` Mark Wielaard
@ 2012-03-26 10:47 ` Pekka Enberg
2012-03-26 10:49 ` Andrew Haley
` (2 more replies)
2012-03-26 10:49 ` Andrew Haley
1 sibling, 3 replies; 11+ messages in thread
From: Pekka Enberg @ 2012-03-26 10:47 UTC (permalink / raw)
To: Mark Wielaard; +Cc: Andrew Haley, classpath-patches, java-patches
On Mon, Mar 26, 2012 at 1:11 PM, Mark Wielaard <mark@klomp.org> wrote:
> On Mon, 2012-03-26 at 10:01 +0100, Andrew Haley wrote:
>> On 03/25/2012 05:08 PM, Gerald Pfeifer wrote:
>> > 2012-03-25 Gerald Pfeifer <gerald@pfeifer.com>
>> >
>> > PR libgcj/52694
>> > * java/io/natVMConsole.cc (IUCLC): Define, if undefined.
>>
>> Sure. WTF is IUCLC anyway? :-)
>
> (map) Input (characters) UpperCase (to) Lower Case.
> It is a non-posix termios extension.
>
> patch should also go into upstream classpath.
Yes, please.
Btw, why are people not fixing GNU Classpath upstream-first?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Fix libjava bootstrap failure around IUCLC
2012-03-26 10:11 ` Mark Wielaard
2012-03-26 10:47 ` [cp-patches] " Pekka Enberg
@ 2012-03-26 10:49 ` Andrew Haley
2012-03-28 19:48 ` Gerald Pfeifer
1 sibling, 1 reply; 11+ messages in thread
From: Andrew Haley @ 2012-03-26 10:49 UTC (permalink / raw)
To: java-patches; +Cc: Gerald Pfeifer
On 03/26/2012 11:11 AM, Mark Wielaard wrote:
> On Mon, 2012-03-26 at 10:01 +0100, Andrew Haley wrote:
>> > On 03/25/2012 05:08 PM, Gerald Pfeifer wrote:
>>> > > 2012-03-25 Gerald Pfeifer <gerald@pfeifer.com>
>>> > >
>>> > > PR libgcj/52694
>>> > > * java/io/natVMConsole.cc (IUCLC): Define, if undefined.
>> >
>> > Sure. WTF is IUCLC anyway? :-)
> (map) Input (characters) UpperCase (to) Lower Case.
> It is a non-posix termios extension.
>
> patch should also go into upstream classpath.
Yes, definitely. Gerald, do you have a classpath ID? If
not, I'll do it.
Andrew.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [cp-patches] Fix libjava bootstrap failure around IUCLC
2012-03-26 10:47 ` [cp-patches] " Pekka Enberg
@ 2012-03-26 10:49 ` Andrew Haley
2012-03-26 10:50 ` Andrew Haley
2012-03-26 10:54 ` Mark Wielaard
2 siblings, 0 replies; 11+ messages in thread
From: Andrew Haley @ 2012-03-26 10:49 UTC (permalink / raw)
To: java-patches
On 03/26/2012 11:47 AM, Pekka Enberg wrote:
> Yes, please.
>
> Btw, why are people not fixing GNU Classpath upstream-first?
Because, I guess, no-one is using it. At least, if they were, this
bug would have been noticed.
Andrew.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [cp-patches] Fix libjava bootstrap failure around IUCLC
2012-03-26 10:47 ` [cp-patches] " Pekka Enberg
2012-03-26 10:49 ` Andrew Haley
@ 2012-03-26 10:50 ` Andrew Haley
2012-03-26 10:53 ` Pekka Enberg
2012-03-26 10:54 ` Mark Wielaard
2 siblings, 1 reply; 11+ messages in thread
From: Andrew Haley @ 2012-03-26 10:50 UTC (permalink / raw)
To: Pekka Enberg; +Cc: Mark Wielaard, classpath-patches, java-patches
On 03/26/2012 11:47 AM, Pekka Enberg wrote:
> On Mon, Mar 26, 2012 at 1:11 PM, Mark Wielaard <mark@klomp.org> wrote:
>> On Mon, 2012-03-26 at 10:01 +0100, Andrew Haley wrote:
>>> On 03/25/2012 05:08 PM, Gerald Pfeifer wrote:
>>>> 2012-03-25 Gerald Pfeifer <gerald@pfeifer.com>
>>>>
>>>> PR libgcj/52694
>>>> * java/io/natVMConsole.cc (IUCLC): Define, if undefined.
>>>
>>> Sure. WTF is IUCLC anyway? :-)
>>
>> (map) Input (characters) UpperCase (to) Lower Case.
>> It is a non-posix termios extension.
>>
>> patch should also go into upstream classpath.
>
> Yes, please.
>
> Btw, why are people not fixing GNU Classpath upstream-first?
Because, I guess, no-one is using it. At least, if they were, this
bug would have been noticed.
Andrew.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [cp-patches] Fix libjava bootstrap failure around IUCLC
2012-03-26 10:50 ` Andrew Haley
@ 2012-03-26 10:53 ` Pekka Enberg
2012-03-26 11:03 ` Mark Wielaard
0 siblings, 1 reply; 11+ messages in thread
From: Pekka Enberg @ 2012-03-26 10:53 UTC (permalink / raw)
To: Andrew Haley; +Cc: Mark Wielaard, classpath-patches, java-patches
On Mon, Mar 26, 2012 at 1:50 PM, Andrew Haley <aph@redhat.com> wrote:
>> Btw, why are people not fixing GNU Classpath upstream-first?
>
> Because, I guess, no-one is using it. At least, if they were, this
> bug would have been noticed.
Right. I'm developing and testing with Fedora and Ubuntu on x86 and I
verify GNU Classpath bootstrap on Darwin at times. I guess Buildbot
would help here.
Pekka
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [cp-patches] Fix libjava bootstrap failure around IUCLC
2012-03-26 10:47 ` [cp-patches] " Pekka Enberg
2012-03-26 10:49 ` Andrew Haley
2012-03-26 10:50 ` Andrew Haley
@ 2012-03-26 10:54 ` Mark Wielaard
2 siblings, 0 replies; 11+ messages in thread
From: Mark Wielaard @ 2012-03-26 10:54 UTC (permalink / raw)
To: Pekka Enberg; +Cc: Andrew Haley, classpath-patches, java-patches
On Mon, 2012-03-26 at 13:47 +0300, Pekka Enberg wrote:
> On Mon, Mar 26, 2012 at 1:11 PM, Mark Wielaard <mark@klomp.org> wrote:
> > On Mon, 2012-03-26 at 10:01 +0100, Andrew Haley wrote:
> >> On 03/25/2012 05:08 PM, Gerald Pfeifer wrote:
> >> > 2012-03-25 Gerald Pfeifer <gerald@pfeifer.com>
> >> >
> >> > PR libgcj/52694
> >> > * java/io/natVMConsole.cc (IUCLC): Define, if undefined.
> >>
> >> Sure. WTF is IUCLC anyway? :-)
> >
> > (map) Input (characters) UpperCase (to) Lower Case.
> > It is a non-posix termios extension.
> >
> > patch should also go into upstream classpath.
>
> Yes, please.
>
> Btw, why are people not fixing GNU Classpath upstream-first?
In this case, because libgcj doesn't use the JNI interface for some of
its native implementations. So this was found in the CNI .cc variant.
The patch should be similar though for the jni .c variant.
Cheers,
Mark
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [cp-patches] Fix libjava bootstrap failure around IUCLC
2012-03-26 10:53 ` Pekka Enberg
@ 2012-03-26 11:03 ` Mark Wielaard
0 siblings, 0 replies; 11+ messages in thread
From: Mark Wielaard @ 2012-03-26 11:03 UTC (permalink / raw)
To: Pekka Enberg; +Cc: Andrew Haley, classpath-patches, java-patches
On Mon, 2012-03-26 at 13:53 +0300, Pekka Enberg wrote:
> On Mon, Mar 26, 2012 at 1:50 PM, Andrew Haley <aph@redhat.com> wrote:
> >> Btw, why are people not fixing GNU Classpath upstream-first?
> >
> > Because, I guess, no-one is using it. At least, if they were, this
> > bug would have been noticed.
>
> Right. I'm developing and testing with Fedora and Ubuntu on x86 and I
> verify GNU Classpath bootstrap on Darwin at times. I guess Buildbot
> would help here.
It is there on GNU/Linux, OpenBSD and Solaris at least, but there might
be termios out there (apparently freebsd at least) that don't have
IUCLC.
Buildbot is on the TODO list :) Of course even with that we need slaves
for some of the more obscure platforms.
Cheers,
Mark
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Fix libjava bootstrap failure around IUCLC
2012-03-26 10:49 ` Andrew Haley
@ 2012-03-28 19:48 ` Gerald Pfeifer
0 siblings, 0 replies; 11+ messages in thread
From: Gerald Pfeifer @ 2012-03-28 19:48 UTC (permalink / raw)
To: Andrew Haley; +Cc: java-patches
On Mon, 26 Mar 2012, Andrew Haley wrote:
>>>>>> 2012-03-25 Gerald Pfeifer <gerald@pfeifer.com>
>>>>>>
>>>>>> PR libgcj/52694
>>>>>> * java/io/natVMConsole.cc (IUCLC): Define, if undefined.
>> patch should also go into upstream classpath.
> Yes, definitely. Gerald, do you have a classpath ID? If
> not, I'll do it.
Thanks for the offer, Andrew. I do not have upstream commit access,
so if you can take care of that it'll be great.
(And thanks for including me on the thread, I was surprised to see
no responses on gcc-patches, and read java-patches online now. ;-)
Gerald
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-03-28 19:48 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-25 16:09 Fix libjava bootstrap failure around IUCLC Gerald Pfeifer
2012-03-26 9:01 ` Andrew Haley
2012-03-26 10:11 ` Mark Wielaard
2012-03-26 10:47 ` [cp-patches] " Pekka Enberg
2012-03-26 10:49 ` Andrew Haley
2012-03-26 10:50 ` Andrew Haley
2012-03-26 10:53 ` Pekka Enberg
2012-03-26 11:03 ` Mark Wielaard
2012-03-26 10:54 ` Mark Wielaard
2012-03-26 10:49 ` Andrew Haley
2012-03-28 19:48 ` Gerald Pfeifer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).