[Bug libgcj/30071] New: make install fails for libjava

[Bug libgcj/30071] New: make install fails for libjava

[r dot emrich at de dot tecosim dot com]

Failure to relink libjvm.la
xgcc: /SCRATCH/gcc-build/HP-UX/hppa2.0w-hp-hpux11.00/install/lib/libgcj.sl: No
such file or directory
libtool: install: error: relink `libjvm.la' with the above command before
installing it

I tracked it down to an install sequence issue.

Makefile.in in the libjava directory contains the following install-exec-am
tag:

install-exec-am: install-binPROGRAMS install-binSCRIPTS \
        install-dbexecDATA install-dbexecLTLIBRARIES \
        install-toolexeclibLTLIBRARIES install-toolexecmainlibDATA
        @$(NORMAL_INSTALL)
        $(MAKE) $(AM_MAKEFLAGS) install-exec-hook

This installs binPROGRAMS and dbexecLTLIBRARIES before toolexeclibLTLIBRARIES
what gives warnings like this:

  /bin/sh ./libtool --mode=install
/appl/shared/gnu/Linux/i686-pc-linux-gnu/bin/install -c 'gij'
'/SCRATCH/gcc-build/Linux/i686-pc-linux-gnu/install/bin/gij'
libtool: install: warning: `libgij.la' has not been installed in
`/SCRATCH/gcc-build/Linux/i686-pc-linux-gnu/install/lib'
libtool: install: warning:
`/SCRATCH/gcc-build/Linux/i686-pc-linux-gnu/gcc-4.2.0/gcc-4.2.0/i686-pc-linux-gnu/libjava/libgcj.la'
has not been installed in
`/SCRATCH/gcc-build/Linux/i686-pc-linux-gnu/install/lib'

and fails on relinking of libjvm.la

xgcc: /SCRATCH/gcc-build/HP-UX/hppa2.0w-hp-hpux11.00/install/lib/libgcj.sl: No
such file or directory
libtool: install: error: relink `libjvm.la' with the above command before
installing it


I changed the install-exec-am tag in the Makefile.in to:

install-exec-am: install-toolexeclibLTLIBRARIES install-toolexecmainlibDATA \
        install-dbexecLTLIBRARIES install-dbexecDATA \
        install-binPROGRAMS install-binSCRIPTS
        @$(NORMAL_INSTALL)
        $(MAKE) $(AM_MAKEFLAGS) install-exec-hook

With this modification bootstrap, make check, and make install succeeds for at
least i686-pc-linux-gnu and hppa2.0w-hp-hpux11.00.


I'm not familiar with the automake machinery. So, somebody who knows the magics 
may help to change the configuration accordingly.


-- 
           Summary: make install fails for libjava
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: r dot emrich at de dot tecosim dot com
 GCC build triplet: hppa2.0w-hp-hpux11.00
  GCC host triplet: hppa2.0w-hp-hpux11.00
GCC target triplet: hppa2.0w-hp-hpux11.00


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071

[Bug libgcj/30071] make install fails for libjava

[tromey at gcc dot gnu dot org]

------- Comment #1 from tromey at gcc dot gnu dot org  2007-01-29 20:00 -------
We can't modify the Makefile.in, since those changes will be lost
the next time someone runs automake.

Could you try adding this to Makefile.am and then re-running automake?
(If you can't re-run automake, let me know and I will send you a patch.)

install-binPROGRAMS: install-toolexeclibLTLIBRARIES

This is not really supported by automake, but really this is working
around an automake bug anyhow.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-01-29 20:00:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071

[Bug libgcj/30071] make install fails for libjava

[r dot emrich at de dot tecosim dot com]

------- Comment #2 from r dot emrich at de dot tecosim dot com  2007-01-30 08:55 -------
Subject: Re:  make install fails for libjava

> Could you try adding this to Makefile.am and then re-running automake?
> (If you can't re-run automake, let me know and I will send you a patch.)

Sorry, I don't have the right automake version around. So, a patch to test
would
be nice.

Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071

[Bug libgcj/30071] make install fails for libjava

[r dot emrich at de dot tecosim dot com]

------- Comment #3 from r dot emrich at de dot tecosim dot com  2007-02-19 16:16 -------
> Could you try adding this to Makefile.am and then re-running automake?
> (If you can't re-run automake, let me know and I will send you a patch.)
> 
> install-binPROGRAMS: install-toolexeclibLTLIBRARIES
> 

I think the only solution is to add the install-exec-am target to the
Makefile.am. 

install-exec-am: install-binPROGRAMS install-binSCRIPTS \
        install-dbexecDATA install-dbexecLTLIBRARIES \
        install-toolexeclibLTLIBRARIES install-toolexecmainlibDATA
        @$(NORMAL_INSTALL)
        $(MAKE) $(AM_MAKEFLAGS) install-exec-hook

This works for me.
Could somebody else try this.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071

[Bug libgcj/30071] make install fails for libjava

[r dot emrich at de dot tecosim dot com]

------- Comment #4 from r dot emrich at de dot tecosim dot com  2007-04-17 07:54 -------
Created an attachment (id=13377)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13377&action=view)
Patch

Proposed patch. I added a new target (install-exec-am) to Makefile.am to
enforce the right installation sequence.

Tested on hppa2.0w-hp-hpux11.00 and i686-pc-linux-gnu.

I hope somebody is able to verify and submit the patch.

In general there is the question, if we need a regular testing of 'make
install,  to detect these kind of problems, which only give warnings on linux
but prevend successful installation on different targets.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071

[Bug libgcj/30071] make install fails for libjava

[tromey at gcc dot gnu dot org]

------- Comment #5 from tromey at gcc dot gnu dot org  2007-07-27 20:11 -------
I don't think we should use this particular patch.  My reason is that
ordering alone is insufficient to guarantee success here, if the user
uses "make -j".

Instead, explicit dependencies should be used.  In addition to fixing the
above these might be a bit more resilient (who knows?) when automake changes.
See comment #1 for an example; basically an install target for an executable
should depend on the needed library install target.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071

[Bug libgcj/30071] make install fails for libjava

[andreast at gcc dot gnu dot org]

------- Comment #6 from andreast at gcc dot gnu dot org  2007-07-29 21:24 -------
install-binPROGRAMS: install-toolexeclibLTLIBRARIES 'overwrites' the
install-binPROGRAMS generated by automake. So this is a no go.

I helped myself with this one:

Index: Makefile.am
===================================================================
--- Makefile.am (revision 126962)
+++ Makefile.am (working copy)
@@ -440,7 +440,7 @@
 $(extra_headers) $(srcdir)/java/lang/Object.h $(srcdir)/java/lang/Class.h:
        @:

-install-exec-hook: install-toolexeclibLTLIBRARIES install-libexecsubPROGRAMS
+install-exec-hook: install-binPROGRAMS install-toolexeclibLTLIBRARIES
install-libexecsubPROGRAMS
 ## Support for libgcj_bc: dummy shared library used only at link-time.
 if USE_LIBGCJ_BC
 ## Install libgcj_bc dummy lib in the target directory. We also need to delete

This one is similar to the one Rainer posted and it might not work if one is
doing a parallel install.

I'll do a test on my farm and see how it behaves on different architectures.

Tom mentioned on IRC that it would be a 'go' for the time being. But one has to
file a bug on automake. (1.9.6 used here). Will do so.


-- 

andreast at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |andreast at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-01-29 20:00:01         |2007-07-29 21:24:48
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071

[Bug libgcj/30071] make install fails for libjava

[andreast at gcc dot gnu dot org]

------- Comment #7 from andreast at gcc dot gnu dot org  2008-02-03 20:54 -------
Created an attachment (id=15089)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15089&action=view)
New trial for the patch in #6, cosmetics only.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071

[Bug libgcj/30071] make install fails for libjava

[andreast at gcc dot gnu dot org]

------- Comment #8 from andreast at gcc dot gnu dot org  2008-02-03 20:56 -------
Ughh, I completely forgot about this PR. But I remember having had some issues
with the generated Makefile.in. It had some more places which were modified
than I expected. So I may actively forgot about this issue.

I usually do the testing of a patch on different archs. And if it succeeds, I
prepare the patch on my main working arch which is OS-X. So here the
preparation caused some headache on my side.
But after jumping in again, I see it seems to be a problem of my environment
rather than the patch itself. Doing the prep on x86-linux or hpux itself shows
only the modification in the patch itself for Makfile.in.

I attach a new version of the patch which should solve the problem for now.

Comments?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071

[Bug libgcj/30071] make install fails for libjava

[andreast at gcc dot gnu dot org]

------- Comment #9 from andreast at gcc dot gnu dot org  2008-02-06 20:46 -------
Subject: Bug 30071

Author: andreast
Date: Wed Feb  6 20:45:21 2008
New Revision: 132159

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132159
Log:
2008-02-06  Andreas Tobler  <a.tobler@schweiz.org>

        PR libgcj/30071
        * Makefile.am (install-exec-hook): Add install-binPROGRAMS.
        * Makefile.in: Regenerate.

Modified:
    trunk/libjava/ChangeLog
    trunk/libjava/Makefile.am
    trunk/libjava/Makefile.in


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071

[Bug libgcj/30071] make install fails for libjava

[andreast at gcc dot gnu dot org]

------- Comment #10 from andreast at gcc dot gnu dot org  2008-02-06 20:46 -------
Committed after ok from Tom T. and a verification install from Dave A.
Thanks.


-- 

andreast at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30071